From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruno =?UTF-8?B?UHLDqW1vbnQ=?= Date: Wed, 22 Sep 2010 19:35:41 +0000 Subject: Re: [Patch, RFC] Make struct fb_info ref-counted with kref Message-Id: <20100922213541.09452849@neptune.home> List-Id: References: <20100919172833.14bf291e@neptune.home> <4C963E99.9080207@gmx.de> <20100919190240.65762511@neptune.home> <4C97B079.8050707@gmx.de> <20100920213258.1218b284@neptune.home> <4C97BF40.6030708@gmx.de> <20100920223608.19b4d177@neptune.home> <4C97E00B.6090103@gmx.de> <20100921075610.1c016c12@pluto.restena.lu> <4C985309.5020205@gmx.de> <20100921090255.410da2d7@pluto.restena.lu> <20100922203927.6ff60f7b@neptune.home> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: James Simmons Cc: Florian Tobias Schandinat , Linux Fbdev development list , Linux Kernel Mailing List , Bernie Thompson On Wed, 22 September 2010 James Simmons wrote: > > > I have a tree at > > > > > > http://git.infradead.org/users/jsimmons/linuxconsole-2.6.git > > > > > > but currently fbcon is broken so I'm tracing down the problem. > > > > Thanks for the reference to your tree! > > > > What's you opinion regarding my changes to fbcon in my RFC patch? > > Are they ok or would you prefer having fbcon changed to stop peeking > > at registered_fb list and just operate directly on fb_info everywhere > > it needs it? (that is let con2fb_map[] point to fb_info instead of > > indexes into registered_fb? (I have a preference for the second one > > and will try it out) > > I'm aiming to kill off registered_fb. I agree that fb_info should be used > directly and we can avoid the ref-count. As for con2fb_map that is a > little more complex. Refcounting can't be fully avoided on fb side but certainly can be on (most of) fbcon side (except around fbcon's calls to fbops.fb_open and fbops.fb_release). Will attempt the fbcon change as a separate patch my ref-counted fb_info patch will depend on. (will probably happen during week-end) Thanks, Bruno