* [PATCH] video/omap: remove duplicated include
@ 2010-10-04 15:43 Nicolas Kaiser
2010-10-04 17:54 ` Tony Lindgren
0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Kaiser @ 2010-10-04 15:43 UTC (permalink / raw)
To: Tomi Valkeinen; +Cc: linux-fbdev, linux-omap, linux-kernel
Remove duplicated include.
Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
---
drivers/video/omap/lcd_omap3beagle.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/video/omap/lcd_omap3beagle.c b/drivers/video/omap/lcd_omap3beagle.c
index ca75cc2..ac715f9 100644
--- a/drivers/video/omap/lcd_omap3beagle.c
+++ b/drivers/video/omap/lcd_omap3beagle.c
@@ -26,7 +26,6 @@
#include <linux/i2c/twl.h>
#include <plat/mux.h>
-#include <plat/mux.h>
#include <asm/mach-types.h>
#include "omapfb.h"
--
1.7.2.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] video/omap: remove duplicated include
2010-10-04 15:43 [PATCH] video/omap: remove duplicated include Nicolas Kaiser
@ 2010-10-04 17:54 ` Tony Lindgren
2010-10-04 18:38 ` [PATCH] video/omap: remove mux.h include Nicolas Kaiser
0 siblings, 1 reply; 5+ messages in thread
From: Tony Lindgren @ 2010-10-04 17:54 UTC (permalink / raw)
To: Nicolas Kaiser; +Cc: Tomi Valkeinen, linux-fbdev, linux-omap, linux-kernel
* Nicolas Kaiser <nikai@nikai.net> [101004 08:35]:
> Remove duplicated include.
>
> Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
> ---
> drivers/video/omap/lcd_omap3beagle.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/omap/lcd_omap3beagle.c b/drivers/video/omap/lcd_omap3beagle.c
> index ca75cc2..ac715f9 100644
> --- a/drivers/video/omap/lcd_omap3beagle.c
> +++ b/drivers/video/omap/lcd_omap3beagle.c
> @@ -26,7 +26,6 @@
> #include <linux/i2c/twl.h>
>
> #include <plat/mux.h>
> -#include <plat/mux.h>
> #include <asm/mach-types.h>
>
> #include "omapfb.h"
Can you please updated this to remove both mux.h entries?
Including mux.h should no longer be needed for omap2/3/4 SoCs
outside arch/arm/mach-omap2 files. For omap1 machines those are still
needed in some drivers..
Regards,
Tony
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] video/omap: remove mux.h include
2010-10-04 17:54 ` Tony Lindgren
@ 2010-10-04 18:38 ` Nicolas Kaiser
2010-10-04 18:47 ` Tony Lindgren
2010-10-05 10:02 ` Tomi Valkeinen
0 siblings, 2 replies; 5+ messages in thread
From: Nicolas Kaiser @ 2010-10-04 18:38 UTC (permalink / raw)
To: Tony Lindgren; +Cc: Tomi Valkeinen, linux-fbdev, linux-omap, linux-kernel
Including mux.h should no longer be needed for omap2/3/4 SoCs
outside arch/arm/mach-omap2 files.
Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
---
drivers/video/omap/lcd_omap3beagle.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/video/omap/lcd_omap3beagle.c b/drivers/video/omap/lcd_omap3beagle.c
index ca75cc2..d7c6c3e 100644
--- a/drivers/video/omap/lcd_omap3beagle.c
+++ b/drivers/video/omap/lcd_omap3beagle.c
@@ -25,8 +25,6 @@
#include <linux/gpio.h>
#include <linux/i2c/twl.h>
-#include <plat/mux.h>
-#include <plat/mux.h>
#include <asm/mach-types.h>
#include "omapfb.h"
--
1.7.2.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] video/omap: remove mux.h include
2010-10-04 18:38 ` [PATCH] video/omap: remove mux.h include Nicolas Kaiser
@ 2010-10-04 18:47 ` Tony Lindgren
2010-10-05 10:02 ` Tomi Valkeinen
1 sibling, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2010-10-04 18:47 UTC (permalink / raw)
To: Nicolas Kaiser; +Cc: Tomi Valkeinen, linux-fbdev, linux-omap, linux-kernel
* Nicolas Kaiser <nikai@nikai.net> [101004 11:32]:
> Including mux.h should no longer be needed for omap2/3/4 SoCs
> outside arch/arm/mach-omap2 files.
>
> Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
Thanks,
Acked-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/video/omap/lcd_omap3beagle.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/omap/lcd_omap3beagle.c b/drivers/video/omap/lcd_omap3beagle.c
> index ca75cc2..d7c6c3e 100644
> --- a/drivers/video/omap/lcd_omap3beagle.c
> +++ b/drivers/video/omap/lcd_omap3beagle.c
> @@ -25,8 +25,6 @@
> #include <linux/gpio.h>
> #include <linux/i2c/twl.h>
>
> -#include <plat/mux.h>
> -#include <plat/mux.h>
> #include <asm/mach-types.h>
>
> #include "omapfb.h"
> --
> 1.7.2.2
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] video/omap: remove mux.h include
2010-10-04 18:38 ` [PATCH] video/omap: remove mux.h include Nicolas Kaiser
2010-10-04 18:47 ` Tony Lindgren
@ 2010-10-05 10:02 ` Tomi Valkeinen
1 sibling, 0 replies; 5+ messages in thread
From: Tomi Valkeinen @ 2010-10-05 10:02 UTC (permalink / raw)
To: ext Nicolas Kaiser
Cc: Tony Lindgren, linux-fbdev@vger.kernel.org,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
On Mon, 2010-10-04 at 20:38 +0200, ext Nicolas Kaiser wrote:
> Including mux.h should no longer be needed for omap2/3/4 SoCs
> outside arch/arm/mach-omap2 files.
>
> Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
Thanks, applied to my tree.
Tomi
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-10-05 10:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-04 15:43 [PATCH] video/omap: remove duplicated include Nicolas Kaiser
2010-10-04 17:54 ` Tony Lindgren
2010-10-04 18:38 ` [PATCH] video/omap: remove mux.h include Nicolas Kaiser
2010-10-04 18:47 ` Tony Lindgren
2010-10-05 10:02 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).