From: Paul Mundt <lethal@linux-sh.org>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 4/4 v2] fbdev: sh_mobile_hdmi: add support for E-EDID parsing
Date: Wed, 10 Nov 2010 04:16:51 +0000 [thread overview]
Message-ID: <20101110041651.GB30715@linux-sh.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1011021145570.4552@axis700.grange>
On Tue, Nov 02, 2010 at 11:47:47AM +0100, Guennadi Liakhovetski wrote:
> --- a/drivers/video/sh_mobile_hdmi.c
> +++ b/drivers/video/sh_mobile_hdmi.c
> @@ -750,7 +753,38 @@ static int sh_hdmi_read_edid(struct sh_hdmi *hdmi, unsigned long *hdmi_rate,
> printk(KERN_CONT "\n");
> #endif
>
> - fb_edid_to_monspecs(edid, &hdmi->monspec);
> + if (!hdmi->edid_blocks) {
> + fb_edid_to_monspecs(edid, &hdmi->monspec);
> + hdmi->edid_blocks = edid[126] + 1;
> +
> + dev_dbg(hdmi->dev, "%d main modes, %d extension blocks\n",
> + hdmi->monspec.modedb_len, hdmi->edid_blocks - 1);
> + } else {
> + dev_dbg(hdmi->dev, "Extension %u detected, DTD start %u\n",
> + edid[0], edid[2]);
> + fb_edid_add_monspecs(edid, &hdmi->monspec);
> + }
> +
Assuming fb_edid_add_monspecs() is changed to hand error values back,
this would probably benefit from being inverted. The fb_edid_to_monspecs()
case looks like a reasonable fallback if fb_did_add_monspecs() fails.
next prev parent reply other threads:[~2010-11-10 4:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-02 10:47 [PATCH 4/4 v2] fbdev: sh_mobile_hdmi: add support for E-EDID parsing Guennadi Liakhovetski
2010-11-10 4:16 ` Paul Mundt [this message]
2010-11-11 13:21 ` [PATCH 4/4 v2] fbdev: sh_mobile_hdmi: add support for E-EDID Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101110041651.GB30715@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).