From: Paul Mundt <lethal@linux-sh.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] s3c-fb: Add support S5PV310 FIMD
Date: Fri, 12 Nov 2010 10:43:28 +0000 [thread overview]
Message-ID: <20101112104327.GB18511@linux-sh.org> (raw)
In-Reply-To: <000001cb8255$feb050b0$fc10f210$%dae@samsung.com>
On Fri, Nov 12, 2010 at 07:40:16PM +0900, Inki Dae wrote:
>
> > -----Original Message-----
> > From: Paul Mundt [mailto:lethal@linux-sh.org]
> > Sent: Friday, November 12, 2010 7:09 PM
> > To: Inki Dae
> > Cc: 'Kukjin Kim'; 'Sangbeom Kim'; linux-arm-kernel@lists.infradead.org;
> > linux-samsung-soc@vger.kernel.org; linux-fbdev@vger.kernel.org; ben-
> > linux@fluff.org; akpm@linux-foundation.org; 'Jonghun Han'
> > Subject: Re: [PATCH 3/4] s3c-fb: Add support S5PV310 FIMD
> >
> > On Fri, Nov 12, 2010 at 06:54:29PM +0900, Inki Dae wrote:
> > > @@ -1314,13 +1319,22 @@ static int __devinit s3c_fb_probe(struct
> > > platform_device *pdev)
> > > sfb->pdata = pd;
> > > sfb->variant = fbdrv->variant;
> > >
> > > - sfb->bus_clk = clk_get(dev, "lcd");
> > > - if (IS_ERR(sfb->bus_clk)) {
> > > - dev_err(dev, "failed to get bus clock\n");
> > > + /* if sclk_name is NULL then it would use bus clock as default. */
> > > + if (!pd->sclk_name)
> > > + sfb->lcd_clk = clk_get(dev, "lcd");
> > > + else
> > > + sfb->lcd_clk = clk_get(dev, pd->sclk_name);
> > > +
> > No, this is totally pointless. Simply establish a clk lookup for the
> > configuration you are running on in your board code
> You mean, call the function at s3c_fb_probe() establishing clk lookup in
> board code?
> Sorry but I could understand. Please give me more detail.
>
I mean use a clkdev lookup for resolving the clock instead of passing
around a string via platform data. Look at the asm/clkdev.h API and all
of the boards that are using it.
next prev parent reply other threads:[~2010-11-12 10:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-18 12:55 [PATCH 0/4] ARM: S5PV310: Add support FIMD Sangbeom Kim
2010-10-18 12:55 ` [PATCH 1/4] ARM: S5PV310: Add FIMD resource definition Sangbeom Kim
2010-10-18 12:55 ` [PATCH 2/4] ARM: S5PV310: Add platform device and helper functions for FIMD Sangbeom Kim
2010-10-18 12:55 ` [PATCH 3/4] s3c-fb: Add support S5PV310 FIMD Sangbeom Kim
2010-10-19 7:22 ` Marek Szyprowski
2010-10-21 3:45 ` Jonghun Han
2010-10-21 4:58 ` Inki Dae
2010-10-25 7:10 ` han jonghun
2010-11-12 5:26 ` Kukjin Kim
2010-11-12 9:54 ` Inki Dae
2010-11-12 10:08 ` Paul Mundt
2010-11-12 10:40 ` Inki Dae
2010-11-12 10:43 ` Paul Mundt [this message]
2010-10-18 12:55 ` [PATCH 4/4] ARM: S5PV310: Add platform data for S5PV310 FIMD and LTE480WV platform-lcd Sangbeom Kim
2010-10-19 6:50 ` [PATCH 4/4] ARM: S5PV310: Add platform data for S5PV310 FIMD and Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101112104327.GB18511@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).