* [PATCH v2] fbdev: modedb: fix CEA modes
@ 2010-11-18 9:45 Arnd Hannemann
2010-11-18 14:14 ` Guennadi Liakhovetski
2010-11-19 7:57 ` Paul Mundt
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Hannemann @ 2010-11-18 9:45 UTC (permalink / raw)
To: linux-fbdev
Some of the modes were missing the correct sync polarities.
This was causing a corrupt or left shifted picture on my TV.
Additionally format #35 had a wrong refresh rate and pixel clock.
This patch fixes those issues.
Signed-off-by: Arnd Hannemann <arnd@arndnet.de>
---
v2: Format #5 had also wrong sync settings, so include the fix in this patch
---
drivers/video/modedb.c | 14 +++++++++-----
1 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/video/modedb.c b/drivers/video/modedb.c
index 9a0ae6c..c3a1825 100644
--- a/drivers/video/modedb.c
+++ b/drivers/video/modedb.c
@@ -289,7 +289,8 @@ const struct fb_videomode cea_modes[64] = {
},
/* #5: 1920x1080i@59.94/60Hz */
[5] = {
- NULL, 60, 1920, 1080, 13763, 148, 88, 15, 2, 44, 5, 0, FB_VMODE_INTERLACED, 0,
+ NULL, 60, 1920, 1080, 13763, 148, 88, 15, 2, 44, 5,
+ FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, FB_VMODE_INTERLACED, 0,
},
/* #7: 720(1440)x480iH@59.94/60Hz */
[7] = {
@@ -305,19 +306,22 @@ const struct fb_videomode cea_modes[64] = {
},
/* #19: 1280x720p@50Hz */
[19] = {
- NULL, 50, 1280, 720, 13468, 220, 440, 20, 5, 40, 5, 0, FB_VMODE_NONINTERLACED, 0,
+ NULL, 50, 1280, 720, 13468, 220, 440, 20, 5, 40, 5,
+ FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED, 0,
},
/* #20: 1920x1080i@50Hz */
[20] = {
- NULL, 50, 1920, 1080, 13480, 148, 528, 15, 5, 528, 5, 0, FB_VMODE_INTERLACED, 0,
+ NULL, 50, 1920, 1080, 13480, 148, 528, 15, 5, 528, 5,
+ FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, FB_VMODE_INTERLACED, 0,
},
/* #32: 1920x1080p@23.98/24Hz */
[32] = {
- NULL, 24, 1920, 1080, 13468, 148, 638, 36, 4, 44, 5, 0, FB_VMODE_NONINTERLACED, 0,
+ NULL, 24, 1920, 1080, 13468, 148, 638, 36, 4, 44, 5,
+ FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED, 0,
},
/* #35: (2880)x480p4x@59.94/60Hz */
[35] = {
- NULL, 50, 2880, 480, 11100, 240, 64, 30, 9, 248, 6, 0, FB_VMODE_NONINTERLACED, 0,
+ NULL, 60, 2880, 480, 9250, 240, 64, 30, 9, 248, 6, 0, FB_VMODE_NONINTERLACED, 0,
},
};
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] fbdev: modedb: fix CEA modes
2010-11-18 9:45 [PATCH v2] fbdev: modedb: fix CEA modes Arnd Hannemann
@ 2010-11-18 14:14 ` Guennadi Liakhovetski
2010-11-19 7:57 ` Paul Mundt
1 sibling, 0 replies; 3+ messages in thread
From: Guennadi Liakhovetski @ 2010-11-18 14:14 UTC (permalink / raw)
To: linux-fbdev
On Thu, 18 Nov 2010, Arnd Hannemann wrote:
> Some of the modes were missing the correct sync polarities.
> This was causing a corrupt or left shifted picture on my TV.
> Additionally format #35 had a wrong refresh rate and pixel clock.
>
> This patch fixes those issues.
>
> Signed-off-by: Arnd Hannemann <arnd@arndnet.de>
Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Thanks
Guennadi
>
> ---
> v2: Format #5 had also wrong sync settings, so include the fix in this patch
> ---
> drivers/video/modedb.c | 14 +++++++++-----
> 1 files changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/video/modedb.c b/drivers/video/modedb.c
> index 9a0ae6c..c3a1825 100644
> --- a/drivers/video/modedb.c
> +++ b/drivers/video/modedb.c
> @@ -289,7 +289,8 @@ const struct fb_videomode cea_modes[64] = {
> },
> /* #5: 1920x1080i@59.94/60Hz */
> [5] = {
> - NULL, 60, 1920, 1080, 13763, 148, 88, 15, 2, 44, 5, 0, FB_VMODE_INTERLACED, 0,
> + NULL, 60, 1920, 1080, 13763, 148, 88, 15, 2, 44, 5,
> + FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, FB_VMODE_INTERLACED, 0,
> },
> /* #7: 720(1440)x480iH@59.94/60Hz */
> [7] = {
> @@ -305,19 +306,22 @@ const struct fb_videomode cea_modes[64] = {
> },
> /* #19: 1280x720p@50Hz */
> [19] = {
> - NULL, 50, 1280, 720, 13468, 220, 440, 20, 5, 40, 5, 0, FB_VMODE_NONINTERLACED, 0,
> + NULL, 50, 1280, 720, 13468, 220, 440, 20, 5, 40, 5,
> + FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED, 0,
> },
> /* #20: 1920x1080i@50Hz */
> [20] = {
> - NULL, 50, 1920, 1080, 13480, 148, 528, 15, 5, 528, 5, 0, FB_VMODE_INTERLACED, 0,
> + NULL, 50, 1920, 1080, 13480, 148, 528, 15, 5, 528, 5,
> + FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, FB_VMODE_INTERLACED, 0,
> },
> /* #32: 1920x1080p@23.98/24Hz */
> [32] = {
> - NULL, 24, 1920, 1080, 13468, 148, 638, 36, 4, 44, 5, 0, FB_VMODE_NONINTERLACED, 0,
> + NULL, 24, 1920, 1080, 13468, 148, 638, 36, 4, 44, 5,
> + FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED, 0,
> },
> /* #35: (2880)x480p4x@59.94/60Hz */
> [35] = {
> - NULL, 50, 2880, 480, 11100, 240, 64, 30, 9, 248, 6, 0, FB_VMODE_NONINTERLACED, 0,
> + NULL, 60, 2880, 480, 9250, 240, 64, 30, 9, 248, 6, 0, FB_VMODE_NONINTERLACED, 0,
> },
> };
>
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] fbdev: modedb: fix CEA modes
2010-11-18 9:45 [PATCH v2] fbdev: modedb: fix CEA modes Arnd Hannemann
2010-11-18 14:14 ` Guennadi Liakhovetski
@ 2010-11-19 7:57 ` Paul Mundt
1 sibling, 0 replies; 3+ messages in thread
From: Paul Mundt @ 2010-11-19 7:57 UTC (permalink / raw)
To: linux-fbdev
On Thu, Nov 18, 2010 at 03:14:44PM +0100, Guennadi Liakhovetski wrote:
> On Thu, 18 Nov 2010, Arnd Hannemann wrote:
>
> > Some of the modes were missing the correct sync polarities.
> > This was causing a corrupt or left shifted picture on my TV.
> > Additionally format #35 had a wrong refresh rate and pixel clock.
> >
> > This patch fixes those issues.
> >
> > Signed-off-by: Arnd Hannemann <arnd@arndnet.de>
>
> Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-11-19 7:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-18 9:45 [PATCH v2] fbdev: modedb: fix CEA modes Arnd Hannemann
2010-11-18 14:14 ` Guennadi Liakhovetski
2010-11-19 7:57 ` Paul Mundt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).