From: Paul Mundt <lethal@linux-sh.org>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: kernel-janitors@vger.kernel.org, Jaya Kumar <jayalk@intworks.biz>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video: arcfb: fix buffer overflow
Date: Wed, 24 Nov 2010 06:25:58 +0000 [thread overview]
Message-ID: <20101124062558.GF11705@linux-sh.org> (raw)
In-Reply-To: <1290361202-15065-1-git-send-email-segoon@openwall.com>
On Sun, Nov 21, 2010 at 08:40:01PM +0300, Vasiliy Kulikov wrote:
> (count + p) is not checked for integer overflow. If p < fbmemlength
> and count = (size_t)(1 - p) (very big unsigned integer) then
> count + p = 1 < fbmemlength and copy_to_user(base_addr+p, buf, count)
> overflows base_addr.
>
> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
Applied, thanks.
next prev parent reply other threads:[~2010-11-24 6:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-21 17:40 [PATCH] video: arcfb: fix buffer overflow Vasiliy Kulikov
2010-11-24 6:25 ` Paul Mundt [this message]
2010-11-24 6:46 ` Dan Carpenter
2010-11-24 6:59 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101124062558.GF11705@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=jayalk@intworks.biz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=segoon@openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).