From: Paul Mundt <lethal@linux-sh.org>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v4+] viafb: I2C/DDC LCD detection for VIA framebuffer
Date: Tue, 30 Nov 2010 06:13:57 +0000 [thread overview]
Message-ID: <20101130061357.GE17114@linux-sh.org> (raw)
In-Reply-To: <4CED3DD5.5080405@bspu.unibel.by>
On Wed, Nov 24, 2010 at 06:31:17PM +0200, Dzianis Kahanovich wrote:
> I2C/DDC LCD detection for VIA framebuffer
>
> Adding legacy I2C/DDC support for VIA framebuffer, used to fix LCD
> panel size and (if "via_active_dev" is empty default) force LCD
> detection. This solving at least defaults on Chrome9 video
> on HP mini 2133 notebook, but must be good in other cases,
> include double-LCD. Also related bugfixes.
>
> v2->v3 patch: original viafb_find_i2c_adapt() code is unsafe (nowere used).
>
> v3->v4 patch: viafbinfo1 is not initilalized if !viafb_dual_fb
> and may cause problems with dual separated LCD. Now dual & SAMM
> code looks safe (will no generate errors).
> +formatting change
>
> Signed-off-by: Dzianis Kahanovich <mahatma@eu.by>
> ---
> diff -pruN a/drivers/video/via/via-core.c b/drivers/video/via/via-core.c
> --- a/drivers/video/via/via-core.c 2010-11-24 00:12:22.000000000 +0200
> +++ b/drivers/video/via/via-core.c 2010-11-24 17:04:00.749999967 +0200
> @@ -2,6 +2,7 @@
> * Copyright 1998-2009 VIA Technologies, Inc. All Rights Reserved.
> * Copyright 2001-2008 S3 Graphics, Inc. All Rights Reserved.
> * Copyright 2009 Jonathan Corbet <corbet@lwn.net>
> + * Copyright 2010 Dzianis Kahanovich <mahatma@eu.by>
> */
>
> /*
> @@ -16,6 +17,8 @@
> #include <linux/interrupt.h>
> #include <linux/platform_device.h>
>
> +extern char *viafb_active_dev;
> +
This belongs in viafbdev.h.
> diff -pruN a/drivers/video/via/viafbdev.c b/drivers/video/via/viafbdev.c
> --- a/drivers/video/via/viafbdev.c 2010-11-21 11:34:11.000000000 +0200
> +++ b/drivers/video/via/viafbdev.c 2010-11-24 00:14:48.070000002 +0200
> @@ -43,7 +43,7 @@ static int viafb_second_size;
> static int viafb_accel = 1;
>
> /* Added for specifying active devices.*/
> -char *viafb_active_dev;
> +char *viafb_active_dev = NULL;
>
This you can just drop.
Since viafb has an active tree, I'll leave this for the viafb folks to
pick up at their leisure.
next prev parent reply other threads:[~2010-11-30 6:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 16:31 [PATCH v4+] viafb: I2C/DDC LCD detection for VIA framebuffer Dzianis Kahanovich
2010-11-30 6:13 ` Paul Mundt [this message]
2010-12-03 11:26 ` Dzianis Kahanovich
-- strict thread matches above, loose matches on Subject: below --
2010-11-24 16:20 [PATCH v4] " Dzianis Kahanovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101130061357.GE17114@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).