From: Tony Lindgren <tony@atomide.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: Mainline OMAP3 breakage (and other OMAP?)
Date: Tue, 14 Dec 2010 18:55:50 +0000 [thread overview]
Message-ID: <20101214185550.GM3054@atomide.com> (raw)
In-Reply-To: <1292329431.6893.113.camel@tubuntu>
* Tomi Valkeinen <tomi.valkeinen@nokia.com> [101214 04:23]:
> >
> > So please, 2MB, or if you object, at the _very_ _least_ 1MB. But
> > definitely not PAGE_SIZE.
Acked-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>
> ---
> drivers/video/omap2/vram.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/omap2/vram.c b/drivers/video/omap2/vram.c
> index 2fd7e52..9441e2e 100644
> --- a/drivers/video/omap2/vram.c
> +++ b/drivers/video/omap2/vram.c
> @@ -551,7 +551,7 @@ void __init omap_vram_reserve_sdram_memblock(void)
> if (!size)
> return;
>
> - size = PAGE_ALIGN(size);
> + size = ALIGN(size, SZ_2M);
>
> if (paddr) {
> if (paddr & ~PAGE_MASK) {
> @@ -576,7 +576,7 @@ void __init omap_vram_reserve_sdram_memblock(void)
> return;
> }
> } else {
> - paddr = memblock_alloc(size, PAGE_SIZE);
> + paddr = memblock_alloc(size, SZ_2M);
> }
>
> memblock_free(paddr, size);
> --
> 1.7.1
>
>
>
prev parent reply other threads:[~2010-12-14 18:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20101202211421.GG10461@n2100.arm.linux.org.uk>
2010-12-02 21:58 ` Mainline OMAP3 breakage (and other OMAP?) Tony Lindgren
2010-12-02 22:16 ` Russell King - ARM Linux
2010-12-02 22:32 ` Tony Lindgren
2010-12-03 3:09 ` Paul Mundt
2010-12-03 8:41 ` Russell King - ARM Linux
2010-12-03 12:10 ` Felipe Contreras
2010-12-03 13:07 ` Russell King - ARM Linux
2010-12-03 13:15 ` Felipe Contreras
2010-12-14 12:23 ` Tomi Valkeinen
2010-12-14 18:55 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101214185550.GM3054@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).