From: Paul Mundt <lethal@linux-sh.org>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 1/2] fbdev: sh-mobile: implement MIPI DSI runtime PM support
Date: Fri, 24 Dec 2010 01:34:41 +0000 [thread overview]
Message-ID: <20101224013440.GF28151@linux-sh.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1012221050400.14483@axis700.grange>
On Thu, Dec 23, 2010 at 01:08:34AM +0100, Guennadi Liakhovetski wrote:
> On Thu, 23 Dec 2010, Paul Mundt wrote:
>
> > On Wed, Dec 22, 2010 at 10:52:18AM +0100, Guennadi Liakhovetski wrote:
> > > @@ -356,7 +360,9 @@ static int __init sh_mipi_probe(struct platform_device *pdev)
> > > goto emap;
> > > }
> > >
> > > - mipi->dsit_clk = clk_get(&pdev->dev, "dsit_clk");
> > > + mipi->dev = &pdev->dev;
> > > +
> > > + mipi->dsit_clk = clk_get(NULL, "dsit_clk");
> >
> > Why did you drop &pdev->dev from clk_get()?
>
> Because that clock is not associated with that device, it sisn't work
> correctly until now. You also cannot associate it with that device
> exclusively, because it serves two devices...
>
I'm not sure I see what the problem is. If there is no special lookup
matching this clock to the device pointer then the lookup will resolve to
whatever generically provides that clock. There is also nothing that
stops someone from providing the same clock to multiple devices via the
same lookup string, this is largely what clock lookups are for in the
first place. Any move away from a device pointer to clk_get() is a step
in the wrong direction.
next prev parent reply other threads:[~2010-12-24 1:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-22 9:52 [PATCH 1/2] fbdev: sh-mobile: implement MIPI DSI runtime PM support Guennadi Liakhovetski
2010-12-22 23:24 ` Paul Mundt
2010-12-23 0:08 ` [PATCH 1/2] fbdev: sh-mobile: implement MIPI DSI runtime PM Guennadi Liakhovetski
2010-12-24 1:34 ` Paul Mundt [this message]
2010-12-24 8:28 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101224013440.GF28151@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).