From: Paul Mundt <lethal@linux-sh.org>
To: Sedat Dilek <sedat.dilek@googlemail.com>
Cc: linux-geode@lists.infradead.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Sedat Dilek <sedat.dilek@gmail.com>
Subject: Re: [PATCH] gx1fb: Fix section mismatch derived from gx1fb_driver variable
Date: Thu, 06 Jan 2011 06:39:07 +0000 [thread overview]
Message-ID: <20110106063906.GB15340@linux-sh.org> (raw)
In-Reply-To: <1294018289-3911-1-git-send-email-sedat.dilek@gmail.com>
On Mon, Jan 03, 2011 at 02:31:29AM +0100, Sedat Dilek wrote:
> diff --git a/drivers/video/geode/gx1fb_core.c b/drivers/video/geode/gx1fb_core.c
> index c6b554f..9fdb115 100644
> --- a/drivers/video/geode/gx1fb_core.c
> +++ b/drivers/video/geode/gx1fb_core.c
> @@ -437,7 +437,7 @@ static struct pci_device_id gx1fb_id_table[] = {
>
> MODULE_DEVICE_TABLE(pci, gx1fb_id_table);
>
> -static struct pci_driver gx1fb_driver = {
> +static struct pci_driver gx1fb_driver __refdata = {
> .name = "gx1fb",
> .id_table = gx1fb_id_table,
> .probe = gx1fb_probe,
The problem seems to be because gx1fb_probe is annotated __init. In the
PCI case you want it to be __devinit, and you're also going to want to
annotate the remove function as __devexit and wrap it up with a
__devexit_p().
next prev parent reply other threads:[~2011-01-06 6:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 19:32 [PATCH] sm501fb: fix section mismatch warning Randy Dunlap
2011-01-03 1:31 ` [PATCH] gx1fb: Fix section mismatch derived from gx1fb_driver variable Sedat Dilek
2011-01-06 6:39 ` Paul Mundt [this message]
2011-06-16 19:31 ` [PATCH] gx1fb: Fix section mismatch warnings Randy Dunlap
2011-06-17 7:15 ` Sedat Dilek
2011-06-24 8:01 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110106063906.GB15340@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-geode@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sedat.dilek@gmail.com \
--cc=sedat.dilek@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).