* [PATCH 05/16] s3c2410fb: don't treat NULL clk as an error [not found] <1294749833-32019-1-git-send-email-jamie@jamieiles.com> @ 2011-01-11 12:43 ` Jamie Iles 2011-01-12 6:00 ` Paul Mundt 2011-01-11 12:43 ` [PATCH 06/16] nuc900fb: " Jamie Iles 1 sibling, 1 reply; 5+ messages in thread From: Jamie Iles @ 2011-01-11 12:43 UTC (permalink / raw) To: linux-kernel; +Cc: Jamie Iles, Vincent Sanders, linux-fbdev clk_get() returns a struct clk cookie to the driver and some platforms may return NULL if they only support a single clock. clk_get() has only failed if it returns a ERR_PTR() encoded pointer. Cc: Vincent Sanders <support@simtec.co.uk> Cc: linux-fbdev@vger.kernel.org Signed-off-by: Jamie Iles <jamie@jamieiles.com> --- drivers/video/s3c2410fb.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/video/s3c2410fb.c b/drivers/video/s3c2410fb.c index 46b4309..61c819e 100644 --- a/drivers/video/s3c2410fb.c +++ b/drivers/video/s3c2410fb.c @@ -13,6 +13,7 @@ #include <linux/module.h> #include <linux/kernel.h> +#include <linux/err.h> #include <linux/errno.h> #include <linux/string.h> #include <linux/mm.h> @@ -918,9 +919,9 @@ static int __devinit s3c24xxfb_probe(struct platform_device *pdev, } info->clk = clk_get(NULL, "lcd"); - if (!info->clk || IS_ERR(info->clk)) { + if (IS_ERR(info->clk)) { printk(KERN_ERR "failed to get lcd clock source\n"); - ret = -ENOENT; + ret = PTR_ERR(info->clk); goto release_irq; } -- 1.7.3.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 05/16] s3c2410fb: don't treat NULL clk as an error 2011-01-11 12:43 ` [PATCH 05/16] s3c2410fb: don't treat NULL clk as an error Jamie Iles @ 2011-01-12 6:00 ` Paul Mundt 0 siblings, 0 replies; 5+ messages in thread From: Paul Mundt @ 2011-01-12 6:00 UTC (permalink / raw) To: Jamie Iles; +Cc: linux-kernel, Vincent Sanders, linux-fbdev On Tue, Jan 11, 2011 at 12:43:42PM +0000, Jamie Iles wrote: > clk_get() returns a struct clk cookie to the driver and some platforms > may return NULL if they only support a single clock. clk_get() has only > failed if it returns a ERR_PTR() encoded pointer. > > Cc: Vincent Sanders <support@simtec.co.uk> > Cc: linux-fbdev@vger.kernel.org > Signed-off-by: Jamie Iles <jamie@jamieiles.com> Applied, thanks. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 06/16] nuc900fb: don't treat NULL clk as an error [not found] <1294749833-32019-1-git-send-email-jamie@jamieiles.com> 2011-01-11 12:43 ` [PATCH 05/16] s3c2410fb: don't treat NULL clk as an error Jamie Iles @ 2011-01-11 12:43 ` Jamie Iles 2011-01-12 1:24 ` Wan ZongShun 1 sibling, 1 reply; 5+ messages in thread From: Jamie Iles @ 2011-01-11 12:43 UTC (permalink / raw) To: linux-kernel; +Cc: Jamie Iles, Wan ZongShun, linux-fbdev clk_get() returns a struct clk cookie to the driver and some platforms may return NULL if they only support a single clock. clk_get() has only failed if it returns a ERR_PTR() encoded pointer. Cc: Wan ZongShun <mcuos.com@gmail.com> Cc: linux-fbdev@vger.kernel.org Signed-off-by: Jamie Iles <jamie@jamieiles.com> --- drivers/video/nuc900fb.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/video/nuc900fb.c b/drivers/video/nuc900fb.c index 81687ed..62498bd 100644 --- a/drivers/video/nuc900fb.c +++ b/drivers/video/nuc900fb.c @@ -15,6 +15,7 @@ */ #include <linux/module.h> #include <linux/kernel.h> +#include <linux/err.h> #include <linux/errno.h> #include <linux/string.h> #include <linux/mm.h> @@ -597,9 +598,9 @@ static int __devinit nuc900fb_probe(struct platform_device *pdev) } fbi->clk = clk_get(&pdev->dev, NULL); - if (!fbi->clk || IS_ERR(fbi->clk)) { + if (IS_ERR(fbi->clk)) { printk(KERN_ERR "nuc900-lcd:failed to get lcd clock source\n"); - ret = -ENOENT; + ret = PTR_ERR(fbi->clk); goto release_irq; } -- 1.7.3.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 06/16] nuc900fb: don't treat NULL clk as an error 2011-01-11 12:43 ` [PATCH 06/16] nuc900fb: " Jamie Iles @ 2011-01-12 1:24 ` Wan ZongShun 2011-01-12 6:00 ` Paul Mundt 0 siblings, 1 reply; 5+ messages in thread From: Wan ZongShun @ 2011-01-12 1:24 UTC (permalink / raw) To: linux-arm-kernel 2011/1/11 Jamie Iles <jamie@jamieiles.com>: > clk_get() returns a struct clk cookie to the driver and some platforms > may return NULL if they only support a single clock. clk_get() has only > failed if it returns a ERR_PTR() encoded pointer. > > Cc: Wan ZongShun <mcuos.com@gmail.com> > Cc: linux-fbdev@vger.kernel.org > Signed-off-by: Jamie Iles <jamie@jamieiles.com> > --- > drivers/video/nuc900fb.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/nuc900fb.c b/drivers/video/nuc900fb.c > index 81687ed..62498bd 100644 > --- a/drivers/video/nuc900fb.c > +++ b/drivers/video/nuc900fb.c > @@ -15,6 +15,7 @@ > */ > #include <linux/module.h> > #include <linux/kernel.h> > +#include <linux/err.h> > #include <linux/errno.h> > #include <linux/string.h> > #include <linux/mm.h> > @@ -597,9 +598,9 @@ static int __devinit nuc900fb_probe(struct platform_device *pdev) > } > > fbi->clk = clk_get(&pdev->dev, NULL); > - if (!fbi->clk || IS_ERR(fbi->clk)) { > + if (IS_ERR(fbi->clk)) { > printk(KERN_ERR "nuc900-lcd:failed to get lcd clock source\n"); > - ret = -ENOENT; > + ret = PTR_ERR(fbi->clk); > goto release_irq; > } > Hi, Thanks for your patch. Acked-by: Wan ZongShun <mcuos.com@gmail.com> > -- > 1.7.3.4 > > -- *linux-arm-kernel mailing list mail addr:linux-arm-kernel@lists.infradead.org you can subscribe by: http://lists.infradead.org/mailman/listinfo/linux-arm-kernel * linux-arm-NUC900 mailing list mail addr:NUC900@googlegroups.com main web: https://groups.google.com/group/NUC900 you can subscribe it by sending me mail: mcuos.com@gmail.com ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 06/16] nuc900fb: don't treat NULL clk as an error 2011-01-12 1:24 ` Wan ZongShun @ 2011-01-12 6:00 ` Paul Mundt 0 siblings, 0 replies; 5+ messages in thread From: Paul Mundt @ 2011-01-12 6:00 UTC (permalink / raw) To: linux-arm-kernel On Wed, Jan 12, 2011 at 09:24:47AM +0800, Wan ZongShun wrote: > 2011/1/11 Jamie Iles <jamie@jamieiles.com>: > > clk_get() returns a struct clk cookie to the driver and some platforms > > may return NULL if they only support a single clock. ??clk_get() has only > > failed if it returns a ERR_PTR() encoded pointer. > > > > Cc: Wan ZongShun <mcuos.com@gmail.com> > > Cc: linux-fbdev@vger.kernel.org > > Signed-off-by: Jamie Iles <jamie@jamieiles.com> > > Thanks for your patch. > > Acked-by: Wan ZongShun <mcuos.com@gmail.com> > Applied, thanks. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-01-12 6:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1294749833-32019-1-git-send-email-jamie@jamieiles.com>
2011-01-11 12:43 ` [PATCH 05/16] s3c2410fb: don't treat NULL clk as an error Jamie Iles
2011-01-12 6:00 ` Paul Mundt
2011-01-11 12:43 ` [PATCH 06/16] nuc900fb: " Jamie Iles
2011-01-12 1:24 ` Wan ZongShun
2011-01-12 6:00 ` Paul Mundt
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).