From: Paul Mundt <lethal@linux-sh.org>
To: Amerigo Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
Yannick Heneault <yheneaul@matrox.com>,
Matthew Garrett <mjg@redhat.com>,
"open list:FRAMEBUFFER LAYER" <linux-fbdev@vger.kernel.org>
Subject: Re: [Patch] video: remove pointless comments in drivers/video/console/vgacon.c
Date: Wed, 19 Jan 2011 06:02:57 +0000 [thread overview]
Message-ID: <20110119060257.GA12205@linux-sh.org> (raw)
In-Reply-To: <1295416803-17651-1-git-send-email-amwang@redhat.com>
On Wed, Jan 19, 2011 at 02:00:02PM +0800, Amerigo Wang wrote:
> Now vgacon_scrollback_startup() uses slab, not bootmem,
> so that comment is obsolete, the rest are useless.
>
> Signed-off-by: WANG Cong <amwang@redhat.com>
>
If you're going to do this then at least follow through and do the rest
of it. The comment is no longer applicable, but then neither is the
__init_refok annotation. Killing off the comment explaining why something
is (or was there) without killing off the thing that is referenced by the
comment is not terribly productive.
next prev parent reply other threads:[~2011-01-19 6:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 6:00 [Patch] video: remove pointless comments in drivers/video/console/vgacon.c Amerigo Wang
2011-01-19 6:02 ` Paul Mundt [this message]
[not found] ` <4D367FD6.1010006@redhat.com>
[not found] ` <20110119061551.GB12205@linux-sh.org>
2011-01-19 6:19 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110119060257.GA12205@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=akpm@linux-foundation.org \
--cc=amwang@redhat.com \
--cc=arnd@arndb.de \
--cc=gregkh@suse.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=yheneaul@matrox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).