From: Sascha Hauer <s.hauer@pengutronix.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] video: Add i.MX23/28 framebuffer driver
Date: Mon, 21 Feb 2011 14:17:31 +0000 [thread overview]
Message-ID: <20110221141730.GO24426@pengutronix.de> (raw)
In-Reply-To: <20110218122946.GF18085@S2100-06.ap.freescale.net>
On Fri, Feb 18, 2011 at 08:29:47PM +0800, Shawn Guo wrote:
> > +
> > +#include <linux/kernel.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/clk.h>
> > +#include <linux/dma-mapping.h>
> > +#include <linux/io.h>
> > +#include <mach/fb.h>
> > +#include <mach/hardware.h>
> > +#include <mach/mxs.h>
> > +
> > +#define REG_SET 4
> > +#define REG_CLR 8
> > +
> We already have these defined in mxs.h
I know, but as Wolfram realized this makes the driver architecture
specific. So I decided to duplicate this here and to remove
mach/hardware.h and mach/mxs.h (obviously still present in the last
posted version)
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2011-02-21 14:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1297850199-1688-1-git-send-email-s.hauer@pengutronix.de>
2011-02-16 9:56 ` [PATCH 1/2] video: Add i.MX23/28 framebuffer driver Sascha Hauer
2011-02-18 5:24 ` Shawn Guo
2011-02-18 8:30 ` Sascha Hauer
2011-02-18 8:57 ` Shawn Guo
2011-02-18 12:29 ` Shawn Guo
2011-02-21 14:17 ` Sascha Hauer [this message]
[not found] <1298880152-28913-1-git-send-email-s.hauer@pengutronix.de>
2011-02-28 8:02 ` Sascha Hauer
[not found] <1297257651-8002-1-git-send-email-s.hauer@pengutronix.de>
2011-02-09 13:20 ` Sascha Hauer
2011-02-09 13:35 ` Lothar Waßmann
2011-02-10 3:16 ` Li Frank-B20596
2011-02-10 8:51 ` Juergen Beisert
2011-02-10 9:15 ` Li Frank-B20596
2011-02-10 9:52 ` Juergen Beisert
2011-02-10 10:37 ` Li Frank-B20596
2011-02-10 11:12 ` Juergen Beisert
2011-02-10 12:23 ` Li Frank-B20596
2011-02-10 9:23 ` Li Frank-B20596
2011-02-10 9:46 ` Juergen Beisert
2011-02-10 10:08 ` Li Frank-B20596
2011-02-10 10:47 ` Wolfram Sang
2011-02-10 11:51 ` Sascha Hauer
2011-02-10 12:32 ` Li Frank-B20596
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110221141730.GO24426@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).