* [PATCH] fbcon: Remove unused 'display *p' variable from
@ 2011-03-24 20:50 Sergey Senozhatsky
2011-03-28 16:18 ` Jesse Barnes
0 siblings, 1 reply; 3+ messages in thread
From: Sergey Senozhatsky @ 2011-03-24 20:50 UTC (permalink / raw)
To: Paul Mundt
Cc: Andrew Morton, Dave Airlie, Jesse Barnes, linux-fbdev,
linux-kernel
fbcon: Remove unused 'display *p' variable from fb_flashcursor()
Signed-of-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
---
drivers/video/console/fbcon.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
index c583934..8745637 100644
--- a/drivers/video/console/fbcon.c
+++ b/drivers/video/console/fbcon.c
@@ -370,7 +370,6 @@ static void fb_flashcursor(struct work_struct *work)
{
struct fb_info *info = container_of(work, struct fb_info, queue);
struct fbcon_ops *ops = info->fbcon_par;
- struct display *p;
struct vc_data *vc = NULL;
int c;
int mode;
@@ -386,7 +385,6 @@ static void fb_flashcursor(struct work_struct *work)
return;
}
- p = &fb_display[vc->vc_num];
c = scr_readw((u16 *) vc->vc_pos);
mode = (!ops->cursor_flash || ops->cursor_state.enable) ?
CM_ERASE : CM_DRAW;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] fbcon: Remove unused 'display *p' variable from
2011-03-24 20:50 [PATCH] fbcon: Remove unused 'display *p' variable from Sergey Senozhatsky
@ 2011-03-28 16:18 ` Jesse Barnes
2011-03-29 3:32 ` [PATCH] fbcon: Remove unused 'display *p' variable from fb_flashcursor() Paul Mundt
0 siblings, 1 reply; 3+ messages in thread
From: Jesse Barnes @ 2011-03-28 16:18 UTC (permalink / raw)
To: Sergey Senozhatsky
Cc: Paul Mundt, Andrew Morton, Dave Airlie, linux-fbdev, linux-kernel
On Thu, 24 Mar 2011 22:50:52 +0200
Sergey Senozhatsky <sergey.senozhatsky@gmail.com> wrote:
> fbcon: Remove unused 'display *p' variable from fb_flashcursor()
>
> Signed-of-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
>
> ---
>
> drivers/video/console/fbcon.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
> index c583934..8745637 100644
> --- a/drivers/video/console/fbcon.c
> +++ b/drivers/video/console/fbcon.c
> @@ -370,7 +370,6 @@ static void fb_flashcursor(struct work_struct *work)
> {
> struct fb_info *info = container_of(work, struct fb_info, queue);
> struct fbcon_ops *ops = info->fbcon_par;
> - struct display *p;
> struct vc_data *vc = NULL;
> int c;
> int mode;
> @@ -386,7 +385,6 @@ static void fb_flashcursor(struct work_struct *work)
> return;
> }
>
> - p = &fb_display[vc->vc_num];
> c = scr_readw((u16 *) vc->vc_pos);
> mode = (!ops->cursor_flash || ops->cursor_state.enable) ?
> CM_ERASE : CM_DRAW;
Looks fine to me, is Paul the lucky owner of fbdev now?
--
Jesse Barnes, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] fbcon: Remove unused 'display *p' variable from fb_flashcursor()
2011-03-28 16:18 ` Jesse Barnes
@ 2011-03-29 3:32 ` Paul Mundt
0 siblings, 0 replies; 3+ messages in thread
From: Paul Mundt @ 2011-03-29 3:32 UTC (permalink / raw)
To: Jesse Barnes
Cc: Sergey Senozhatsky, Andrew Morton, Dave Airlie, linux-fbdev,
linux-kernel
On Mon, Mar 28, 2011 at 09:18:46AM -0700, Jesse Barnes wrote:
> On Thu, 24 Mar 2011 22:50:52 +0200
> Sergey Senozhatsky <sergey.senozhatsky@gmail.com> wrote:
>
> > fbcon: Remove unused 'display *p' variable from fb_flashcursor()
> >
> > Signed-of-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> >
>
> Looks fine to me, is Paul the lucky owner of fbdev now?
>
Seems so. I'll roll the patch in with the next batch of fixes.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-29 3:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-24 20:50 [PATCH] fbcon: Remove unused 'display *p' variable from Sergey Senozhatsky
2011-03-28 16:18 ` Jesse Barnes
2011-03-29 3:32 ` [PATCH] fbcon: Remove unused 'display *p' variable from fb_flashcursor() Paul Mundt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).