From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Paul Mundt <lethal@linux-sh.org>,
Andrew Morton <akpm@linux-foundation.org>,
Dave Airlie <airlied@redhat.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fbcon: Remove unused 'display *p' variable from
Date: Mon, 28 Mar 2011 16:18:46 +0000 [thread overview]
Message-ID: <20110328091846.485dfef0@jbarnes-desktop> (raw)
In-Reply-To: <20110324205052.GA4238@swordfish>
On Thu, 24 Mar 2011 22:50:52 +0200
Sergey Senozhatsky <sergey.senozhatsky@gmail.com> wrote:
> fbcon: Remove unused 'display *p' variable from fb_flashcursor()
>
> Signed-of-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
>
> ---
>
> drivers/video/console/fbcon.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
> index c583934..8745637 100644
> --- a/drivers/video/console/fbcon.c
> +++ b/drivers/video/console/fbcon.c
> @@ -370,7 +370,6 @@ static void fb_flashcursor(struct work_struct *work)
> {
> struct fb_info *info = container_of(work, struct fb_info, queue);
> struct fbcon_ops *ops = info->fbcon_par;
> - struct display *p;
> struct vc_data *vc = NULL;
> int c;
> int mode;
> @@ -386,7 +385,6 @@ static void fb_flashcursor(struct work_struct *work)
> return;
> }
>
> - p = &fb_display[vc->vc_num];
> c = scr_readw((u16 *) vc->vc_pos);
> mode = (!ops->cursor_flash || ops->cursor_state.enable) ?
> CM_ERASE : CM_DRAW;
Looks fine to me, is Paul the lucky owner of fbdev now?
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2011-03-28 16:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 20:50 [PATCH] fbcon: Remove unused 'display *p' variable from Sergey Senozhatsky
2011-03-28 16:18 ` Jesse Barnes [this message]
2011-03-29 3:32 ` [PATCH] fbcon: Remove unused 'display *p' variable from fb_flashcursor() Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110328091846.485dfef0@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=airlied@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=lethal@linux-sh.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).