* [patch] backlight/ld9040.c: testing the wrong variable in
@ 2011-03-29 3:19 Dan Carpenter
2011-03-29 4:37 ` Donghwa Lee
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-03-29 3:19 UTC (permalink / raw)
To: linux-fbdev
We should be testing "bd" here instead of "ld". It's a copy and
paste bug.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/video/backlight/ld9040.c b/drivers/video/backlight/ld9040.c
index 7281b25..9e81d69 100644
--- a/drivers/video/backlight/ld9040.c
+++ b/drivers/video/backlight/ld9040.c
@@ -701,8 +701,8 @@ static int ld9040_probe(struct spi_device *spi)
bd = backlight_device_register("ld9040-bl", &spi->dev,
lcd, &ld9040_backlight_ops, NULL);
- if (IS_ERR(ld)) {
- ret = PTR_ERR(ld);
+ if (IS_ERR(bd)) {
+ ret = PTR_ERR(bd);
goto out_free_lcd;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch] backlight/ld9040.c: testing the wrong variable in
2011-03-29 3:19 [patch] backlight/ld9040.c: testing the wrong variable in Dan Carpenter
@ 2011-03-29 4:37 ` Donghwa Lee
0 siblings, 0 replies; 2+ messages in thread
From: Donghwa Lee @ 2011-03-29 4:37 UTC (permalink / raw)
To: linux-fbdev
On 2011-03-29, Dan Carpenter wrote:
> We should be testing "bd" here instead of "ld". It's a copy and
> paste bug.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/video/backlight/ld9040.c b/drivers/video/backlight/ld9040.c
> index 7281b25..9e81d69 100644
> --- a/drivers/video/backlight/ld9040.c
> +++ b/drivers/video/backlight/ld9040.c
> @@ -701,8 +701,8 @@ static int ld9040_probe(struct spi_device *spi)
>
> bd = backlight_device_register("ld9040-bl", &spi->dev,
> lcd, &ld9040_backlight_ops, NULL);
> - if (IS_ERR(ld)) {
> - ret = PTR_ERR(ld);
> + if (IS_ERR(bd)) {
> + ret = PTR_ERR(bd);
> goto out_free_lcd;
> }
>
>
Yes, It's my mistake. It has to be changed as you said.
Thank you,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-29 4:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-29 3:19 [patch] backlight/ld9040.c: testing the wrong variable in Dan Carpenter
2011-03-29 4:37 ` Donghwa Lee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).