From: Paul Mundt <lethal@linux-sh.org>
To: Ondrej Zajicek <santiago@crfreenet.org>
Cc: Ondrej Zary <linux@rainbow-software.org>,
linux-fbdev@vger.kernel.org,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] s3fb: add DDC support
Date: Mon, 04 Apr 2011 08:42:03 +0000 [thread overview]
Message-ID: <20110404084200.GD28208@linux-sh.org> (raw)
In-Reply-To: <20110404083316.GB9431@localhost>
On Mon, Apr 04, 2011 at 10:33:16AM +0200, Ondrej Zajicek wrote:
> On Sun, Apr 03, 2011 at 10:36:15PM +0200, Ondrej Zary wrote:
> > Add I2C support for the DDC bus and also default mode initialization by
> > reading monitor EDID to the s3fb driver.
> >
> > Tested on Trio64V+ (2 cards), Trio64V2/DX, Virge (3 cards),
> > Virge/DX (3 cards), Virge/GX2, Trio3D/2X (4 cards), Trio3D.
> >
> > Will probably not work on Trio32 - my 2 cards have DDC support in BIOS that
> > looks different from the other cards but the DDC pins on the VGA connector
> > are not connected.
> >
> > Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
>
> Acked-by: Ondrej Zajicek <santiago@crfreenet.org>
>
Is there much reason to leave this optional? Or are you simply waiting
for testing feedback from Trio32 users before default-enabling it?
It would generally be nice to avoid these sorts of config options for a
specific driver if it already is quite capable of handling the
unsupported cases and has a reasonable fallback on defaults via the error
path.
next prev parent reply other threads:[~2011-04-04 8:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-03 20:36 [PATCH v3] s3fb: add DDC support Ondrej Zary
2011-04-04 8:33 ` Ondrej Zajicek
2011-04-04 8:42 ` Paul Mundt [this message]
2011-04-04 9:25 ` Ondrej Zary
2011-04-06 17:01 ` Paul Mundt
2011-04-04 20:44 ` Ondrej Zary
2011-04-07 17:01 ` Paul Mundt
2011-04-11 21:44 ` [PATCH v4] " Ondrej Zary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110404084200.GD28208@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=santiago@crfreenet.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).