* [PATCH 6/6] drivers/video/bfin-lq035q1-fb.c: introduce missing kfree
@ 2011-04-01 14:23 Julia Lawall
2011-04-02 5:05 ` Mike Frysinger
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2011-04-01 14:23 UTC (permalink / raw)
To: Paul Mundt; +Cc: kernel-janitors, linux-fbdev, linux-kernel
Error handling code following a kmalloc should free the allocated data.
The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@
x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x = NULL) S
<... when != x
when != if (...) { <+...x...+> }
(
x->f1 = E
|
(x->f1 = NULL || ...)
|
f(...,x->f1,...)
)
...>
(
return \(0\|<+...x...+>\|ptr\);
|
return@p2 ...;
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/video/bfin-lq035q1-fb.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/video/bfin-lq035q1-fb.c b/drivers/video/bfin-lq035q1-fb.c
index c8e1f04..23b6c4b 100644
--- a/drivers/video/bfin-lq035q1-fb.c
+++ b/drivers/video/bfin-lq035q1-fb.c
@@ -154,8 +154,10 @@ static int __devinit lq035q1_spidev_probe(struct spi_device *spi)
ret = lq035q1_control(spi, LQ035_SHUT_CTL, LQ035_ON);
ret |= lq035q1_control(spi, LQ035_DRIVER_OUTPUT_CTL, ctl->mode);
- if (ret)
+ if (ret) {
+ kfree(ctl);
return ret;
+ }
spi_set_drvdata(spi, ctl);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 6/6] drivers/video/bfin-lq035q1-fb.c: introduce missing kfree
2011-04-01 14:23 [PATCH 6/6] drivers/video/bfin-lq035q1-fb.c: introduce missing kfree Julia Lawall
@ 2011-04-02 5:05 ` Mike Frysinger
2011-04-06 16:46 ` Paul Mundt
0 siblings, 1 reply; 3+ messages in thread
From: Mike Frysinger @ 2011-04-02 5:05 UTC (permalink / raw)
To: Julia Lawall; +Cc: Paul Mundt, kernel-janitors, linux-fbdev, linux-kernel
On Fri, Apr 1, 2011 at 10:23, Julia Lawall wrote:
> Error handling code following a kmalloc should free the allocated data.
Acked-by: Mike Frysinger <vapier@gentoo.org>
-mike
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 6/6] drivers/video/bfin-lq035q1-fb.c: introduce missing kfree
2011-04-02 5:05 ` Mike Frysinger
@ 2011-04-06 16:46 ` Paul Mundt
0 siblings, 0 replies; 3+ messages in thread
From: Paul Mundt @ 2011-04-06 16:46 UTC (permalink / raw)
To: Mike Frysinger; +Cc: Julia Lawall, kernel-janitors, linux-fbdev, linux-kernel
On Sat, Apr 02, 2011 at 01:05:57AM -0400, Mike Frysinger wrote:
> On Fri, Apr 1, 2011 at 10:23, Julia Lawall wrote:
> > Error handling code following a kmalloc should free the allocated data.
>
> Acked-by: Mike Frysinger <vapier@gentoo.org>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-06 16:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-01 14:23 [PATCH 6/6] drivers/video/bfin-lq035q1-fb.c: introduce missing kfree Julia Lawall
2011-04-02 5:05 ` Mike Frysinger
2011-04-06 16:46 ` Paul Mundt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).