[PATCH 1/2] savagefb: Replace magic register address with define

[PATCH 1/2] savagefb: Replace magic register address with define

[Tormod Volden]

From: Tormod Volden <debian.tormod@gmail.com>

MM_SERIAL1 was already defined, but not used.

Signed-off-by: Tormod Volden <debian.tormod@gmail.com>
---

Hi,

There was this unused define, and the one single use of the constant, so
I think somebody just forgot to use it.

Regards,
Tormod

 drivers/video/savage/savagefb-i2c.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/savage/savagefb-i2c.c b/drivers/video/savage/savagefb-i2c.c
index b16e613..58c8a3c 100644
--- a/drivers/video/savage/savagefb-i2c.c
+++ b/drivers/video/savage/savagefb-i2c.c
@@ -191,7 +191,7 @@ void savagefb_create_i2c_busses(struct fb_info *info)
 		par->chan.algo.getscl = prosavage_gpio_getscl;
 		break;
 	case FB_ACCEL_SAVAGE2000:
-		par->chan.reg         = 0xff20;
+		par->chan.reg         = MM_SERIAL1;
 		par->chan.ioaddr      = par->mmio.vbase;
 		par->chan.algo.setsda = savage4_gpio_setsda;
 		par->chan.algo.setscl = savage4_gpio_setscl;
-- 
1.7.0.4

Re: [PATCH 1/2] savagefb: Replace magic register address with define

[Paul Mundt]

On Sun, Apr 03, 2011 at 02:54:04PM +0200, Tormod Volden wrote:
> MM_SERIAL1 was already defined, but not used.
> 
> Signed-off-by: Tormod Volden <debian.tormod@gmail.com>

On Sun, Apr 03, 2011 at 02:54:05PM +0200, Tormod Volden wrote:
> In practice this means enabling I2C (for DDC2) on all prosavage cards,
> like the xorg ddx does. The savage4 and savage2000 families have only
> one member each, so there is no change for those.
> 
> Tested on TwisterK.
> 
> Signed-off-by: Tormod Volden <debian.tormod@gmail.com>

On Sun, Apr 03, 2011 at 02:54:06PM +0200, Tormod Volden wrote:
> The else clause was not needed after the cleanup in commit
> b8901b091db260b0f0101d6395ce5c6016835a47
> 
> Signed-off-by: Tormod Volden <debian.tormod@gmail.com>

These all look fine. All applied, thanks.