From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: anish singh <anish198519851985@gmail.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
lethal@linux-sh.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] trivial: Changed the printk loglevel when not able
Date: Wed, 18 May 2011 11:26:47 +0000 [thread overview]
Message-ID: <20110518112647.GA15386@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20110518112436.GH5913@n2100.arm.linux.org.uk>
On Wed, May 18, 2011 at 12:24:36PM +0100, Russell King - ARM Linux wrote:
> On Wed, May 18, 2011 at 04:27:47PM +0530, anish singh wrote:
> > Got it.So should i change both as KERN_WARN and resend?
>
> Much better would be to change it to pr_warn() or even
> dev_warn(&dev->dev, ...).
Actually, make that pr_err() or dev_err(). Both printks in clcdfb_probe()
are errors and so should be reported at error severity - they cause things
to stop working and so they're not just a warning.
prev parent reply other threads:[~2011-05-18 11:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 17:41 [PATCH 2/2] trivial: Changed the printk loglevel when not able to anish
2011-05-17 17:43 ` Catalin Marinas
[not found] ` <BANLkTi=ngJiMyVt4AMqcWUSUM2EVXtjRQQ@mail.gmail.com>
2011-05-18 10:15 ` [PATCH 2/2] trivial: Changed the printk loglevel when not able Catalin Marinas
[not found] ` <BANLkTinZ6d1=58Y0SCL72Jh3F6R8yfqE-Q@mail.gmail.com>
2011-05-18 11:01 ` Catalin Marinas
2011-05-18 11:24 ` Russell King - ARM Linux
2011-05-18 11:26 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110518112647.GA15386@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=anish198519851985@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=lethal@linux-sh.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).