From: Paul Mundt <lethal@linux-sh.org>
To: anish <anish198519851985@gmail.com>
Cc: linux@arm.linux.org.uk, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch 1/2] trivial: amba-clcd.c preferred form of passing size of structure
Date: Mon, 23 May 2011 07:13:01 +0000 [thread overview]
Message-ID: <20110523071301.GK5206@linux-sh.org> (raw)
In-Reply-To: <1305742026.8771.26.camel@anish-desktop>
On Wed, May 18, 2011 at 11:37:06PM +0530, anish wrote:
> The preferred form for passing a size of a struct is the following:
> p = kmalloc(sizeof(*p), ...);
> Please refer Documentation/Codingstyle chapter 14
>
> Signed-off-by: anish kumar <anish198519851985@gmail.com>
>
That's pretty subjective, and ultimately depends on the author. I
personally prefer to have it written out, but then I don't randomly
change my structure types around either, so the "bug" alluded to isn't
really an issue. I'm not sure I buy the impaired readability argument,
either..
prev parent reply other threads:[~2011-05-23 7:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 18:19 [patch 1/2] trivial: amba-clcd.c preferred form of passing size of anish
2011-05-23 7:13 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110523071301.GK5206@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=anish198519851985@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).