From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sascha Hauer Date: Wed, 01 Jun 2011 17:49:15 +0000 Subject: Re: [PATCH 8/10] drivers/video/imxfb.c: add missing clk_put Message-Id: <20110601174915.GL23771@pengutronix.de> List-Id: References: <1306948213-20767-8-git-send-email-julia@diku.dk> In-Reply-To: <1306948213-20767-8-git-send-email-julia@diku.dk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Wed, Jun 01, 2011 at 07:10:11PM +0200, Julia Lawall wrote: > From: Julia Lawall > > Reorder the labels at the end of the function to correspond to the order in > which the resources are allocated. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // > @r exists@ > expression e1,e2; > statement S; > @@ > > e1 = clk_get@p1(...); > ... when != e1 = e2 > when != clk_put(e1) > when any > if (...) { ... when != clk_put(e1) > when != if (...) { ... clk_put(e1) ... } > * return@p3 ...; > } else S > // > > Signed-off-by: Julia Lawall Acked-by: Sascha Hauer > > --- > drivers/video/imxfb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/imxfb.c b/drivers/video/imxfb.c > index d2ccfd6..f135dbe 100644 > --- a/drivers/video/imxfb.c > +++ b/drivers/video/imxfb.c > @@ -856,10 +856,10 @@ failed_platform_init: > dma_free_writecombine(&pdev->dev,fbi->map_size,fbi->map_cpu, > fbi->map_dma); > failed_map: > - clk_put(fbi->clk); > -failed_getclock: > iounmap(fbi->regs); > failed_ioremap: > + clk_put(fbi->clk); > +failed_getclock: > release_mem_region(res->start, resource_size(res)); > failed_req: > kfree(info->pseudo_palette); > > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |