From: Paul Mundt <lethal@linux-sh.org>
To: linux-fbdev@vger.kernel.org
Subject: Re: [Patch 2/2 resend] Prevent vga16fb from accessing hw after it was unregistered
Date: Mon, 06 Jun 2011 03:07:04 +0000 [thread overview]
Message-ID: <20110606030704.GD26101@linux-sh.org> (raw)
In-Reply-To: <20110524223221.741ffbc0@neptune.home>
On Tue, May 24, 2011 at 10:32:21PM +0200, Bruno Pr??mont wrote:
> diff --git a/drivers/video/fbmem.c b/drivers/video/fbmem.c
> index 5aac00e..bd9f93b 100644
> --- a/drivers/video/fbmem.c
> +++ b/drivers/video/fbmem.c
> @@ -1661,6 +1661,11 @@ static int do_unregister_framebuffer(struct fb_info *fb_info)
> device_destroy(fb_class, MKDEV(FB_MAJOR, i));
> event.info = fb_info;
> fb_notifier_call_chain(FB_EVENT_FB_UNREGISTERED, &event);
> + if (fb_info->fbops->fb_unregistered) {
> + mutex_lock(&fb_info->lock);
> + fb_info->fbops->fb_unregistered(fb_info);
> + mutex_unlock(&fb_info->lock);
> + }
>
> /* this may free fb info */
> put_fb_info(fb_info);
I'm not sure I really see the point, given that you can already do all of
the same work by tying in to the notifier chain. See for example the
sh_mobile_hdmi driver and its unreg notifier.
next prev parent reply other threads:[~2011-06-06 3:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-24 20:32 [Patch 2/2 resend] Prevent vga16fb from accessing hw after it was Bruno Prémont
2011-06-06 3:07 ` Paul Mundt [this message]
2011-06-06 20:08 ` [Patch 2/2 resend] Prevent vga16fb from accessing hw after it Bruno Prémont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110606030704.GD26101@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).