From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, efault@gmx.de,
Arne Jansen <lists@die-jansens.de>,
PaulMundt <lethal@linux-sh.org>,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 1/3] printk: Release console_sem after logbuf_lock
Date: Fri, 10 Jun 2011 12:34:16 +0000 [thread overview]
Message-ID: <20110610123416.GA12451@elte.hu> (raw)
In-Reply-To: <1307709030.3941.134.camel@twins>
* Peter Zijlstra <peterz@infradead.org> wrote:
> thinking that that would have my printk stmts appear on both the
> fbcon as well as the serial line. But they fail to appear on the
> latency tracer (current max was 165us waking an idle cpu).
Have you removed this bit:
spin_unlock(&logbuf_lock);
stop_critical_timings(); /* don't trace print latency */
call_console_drivers(_con_start, _log_end);
start_critical_timings();
local_irq_restore(flags);
which hides the latencies from the latency tracer?
Thanks,
Ingo
next prev parent reply other threads:[~2011-06-10 12:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110609130647.937204592@chello.nl>
[not found] ` <20110609131307.493181962@chello.nl>
[not found] ` <20110609130617.f8aca966.akpm@linux-foundation.org>
[not found] ` <20110609202707.GA28951@elte.hu>
[not found] ` <1307652883.2497.1028.camel@laptop>
[not found] ` <20110609140714.fc9ea187.akpm@linux-foundation.org>
[not found] ` <alpine.LSU.2.00.1106091655560.2710@sister.anvils>
[not found] ` <1307705311.3941.118.camel@twins>
2011-06-10 12:30 ` [PATCH 1/3] printk: Release console_sem after logbuf_lock Peter Zijlstra
2011-06-10 12:34 ` Ingo Molnar [this message]
2011-06-10 12:41 ` Peter Zijlstra
2011-06-10 12:42 ` Peter Zijlstra
2011-06-23 19:03 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110610123416.GA12451@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=efault@gmx.de \
--cc=hughd@google.com \
--cc=lethal@linux-sh.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@die-jansens.de \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).