From: Andrew Morton <akpm@linux-foundation.org>
To: linux-fbdev@vger.kernel.org
Subject: Re: [Bugme-new] [Bug 39842] New: savagefb.h CARD SERIES definition
Date: Thu, 28 Jul 2011 23:27:52 +0000 [thread overview]
Message-ID: <20110728162752.3a4602e4.akpm@linux-foundation.org> (raw)
(switched to email. Please respond via emailed reply-to-all, not via the
bugzilla web interface).
On Sat, 23 Jul 2011 10:20:41 GMT
bugzilla-daemon@bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id9842
>
> Summary: savagefb.h CARD SERIES definition typo
> Product: Drivers
> Version: 2.5
> Kernel Version: 3.0.0
> Platform: All
> OS/Version: Linux
> Tree: Mainline
> Status: NEW
> Severity: normal
> Priority: P1
> Component: Video(Other)
> AssignedTo: drivers_video-other@kernel-bugs.osdl.org
> ReportedBy: jpsinthemix@verizon.net
> Regression: Yes
>
>
> I have an old T22 Thinkpad with integrated Savage/IX-MV video. As of linux-3.0,
> the video is non-functional; the PC either hard hangs immediately or has
> totally garbled video, and then hard hangs, as soon as I attempt to edit a file
> or cat a file with more than a screen-full of text. The foregoing details are
> actually not important any more as in looking at the code changes I discovered
> a typo in linux-3.0.0/drivers/video/savage/savagefb.h and have applied the
> following patch to fix the issue:
>
> --- linux-3.0.0.old/drivers/video/savage/savagefb.h 2011-07-21
> 22:17:23.000000000 -0400
> +++ linux-3.0.0.new/drivers/video/savage/savagefb.h 2011-07-23
> 05:13:33.801215293 -0400
> @@ -55,7 +55,7 @@
>
> #define S3_SAVAGE3D_SERIES(chip) ((chip>=S3_SAVAGE3D) &&
> (chip<=S3_SAVAGE_MX))
>
> -#define S3_SAVAGE4_SERIES(chip) ((chip>=S3_SAVAGE4) ||
> (chip<=S3_PROSAVAGEDDR))
> +#define S3_SAVAGE4_SERIES(chip) ((chip>=S3_SAVAGE4) &&
> (chip<=S3_PROSAVAGEDDR))
>
> #define S3_SAVAGE_MOBILE_SERIES(chip) ((chip=S3_SAVAGE_MX) ||
> (chip=S3_SUPERSAVAGE))
>
>
> P.S. Many, many thanks for lifting the 800x600 resolution limit! I've been
> using a patch/hack to bump the limit to 1024x768 for an very long time...
> John
Please resend that fix as a formal signed-off-patch as a reply-to-all
to this email? Documentation/SubmittingPatches has some tips.
Thanks.
next reply other threads:[~2011-07-28 23:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-28 23:27 Andrew Morton [this message]
2011-07-29 12:20 ` [Bugme-new] [Bug 39842] New: savagefb.h CARD SERIES definition John Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110728162752.3a4602e4.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).