From: Ondrej Zary <linux@rainbow-software.org>
To: Tabi Timur-B04825 <B04825@freescale.com>
Cc: "linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
Paul Mundt <lethal@linux-sh.org>,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3.1] [resend] Resurrect Intel740 driver: i740fb
Date: Sat, 19 Nov 2011 11:11:02 +0000 [thread overview]
Message-ID: <201111191211.08704.linux@rainbow-software.org> (raw)
In-Reply-To: <CAOZdJXVx88nEAQkL13n1QXVw=kOe03QsD=pffHoZ8gecL7u8dA@mail.gmail.com>
On Saturday 19 November 2011 00:53:27 Tabi Timur-B04825 wrote:
> On Fri, Nov 18, 2011 at 2:54 PM, Ondrej Zary <linux@rainbow-software.org>
wrote:
> > Hello,
> > this is an v3 attempt to resurrect an old (like 2.4.19) out-of-tree
> > driver for Intel740 graphics cards and modify it for recent kernels. The
> > old driver is located at:
> > http://sourceforge.net/projects/i740fbdev/files/
>
> Would you please run checkpatch.pl on the patch and fix the complaints
> it has? I get this:
>
> total: 45 errors, 67 warnings, 1619 lines checked
>
> This patch has tons of style problems.
The 45 errors are in i740_calc_fifo(), which now looks good and is readable.
Reformatting according to checkpatch makes it look bad and unredable. This
was already discussed before.
The warnings are lines over 80 characters, which are common in most fb
drivers. Splitting them makes code hard to read.
--
Ondrej Zary
next prev parent reply other threads:[~2011-11-19 11:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 20:54 [PATCH v3.1] [resend] Resurrect Intel740 driver: i740fb Ondrej Zary
2011-11-18 23:53 ` Tabi Timur-B04825
2011-11-19 11:11 ` Ondrej Zary [this message]
2011-12-03 21:45 ` Florian Tobias Schandinat
2011-12-04 2:35 ` Tabi Timur-B04825
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111191211.08704.linux@rainbow-software.org \
--to=linux@rainbow-software.org \
--cc=B04825@freescale.com \
--cc=FlorianSchandinat@gmx.de \
--cc=lethal@linux-sh.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).