[PATCH 06/57] fbdev: sh_mobile_hdmi: Don't access LCDC channel in notifier callback

linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH 06/57] fbdev: sh_mobile_hdmi: Don't access LCDC channel in notifier callback
@ 2011-12-13 14:02 Laurent Pinchart
  2011-12-13 23:02 ` [PATCH 06/57] fbdev: sh_mobile_hdmi: Don't access LCDC channel Guennadi Liakhovetski
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Laurent Pinchart @ 2011-12-13 14:02 UTC (permalink / raw)
  To: linux-fbdev

Instead of relying on info->par being a pointer to an LCDC channel, cast
the notifier block pointer to an sh_hdmi pointer.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 drivers/video/sh_mobile_hdmi.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/video/sh_mobile_hdmi.c b/drivers/video/sh_mobile_hdmi.c
index 647ba98..b1e90f5 100644
--- a/drivers/video/sh_mobile_hdmi.c
+++ b/drivers/video/sh_mobile_hdmi.c
@@ -225,6 +225,8 @@ struct sh_hdmi {
 	struct notifier_block notifier;
 };
 
+#define notifier_to_hdmi(n)	container_of(n, struct sh_hdmi, notifier)
+
 static void hdmi_write(struct sh_hdmi *hdmi, u8 data, u8 reg)
 {
 	iowrite8(data, hdmi->base + reg);
@@ -1204,9 +1206,7 @@ static int sh_hdmi_notify(struct notifier_block *nb,
 {
 	struct fb_event *event = data;
 	struct fb_info *info = event->info;
-	struct sh_mobile_lcdc_chan *ch = info->par;
-	struct sh_mobile_lcdc_board_cfg	*board_cfg = &ch->cfg.board_cfg;
-	struct sh_hdmi *hdmi = board_cfg->board_data;
+	struct sh_hdmi *hdmi = notifier_to_hdmi(nb);
 
 	if (!hdmi || nb != &hdmi->notifier || hdmi->info != info)
 		return NOTIFY_DONE;
-- 
1.7.3.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 06/57] fbdev: sh_mobile_hdmi: Don't access LCDC channel
  2011-12-13 14:02 [PATCH 06/57] fbdev: sh_mobile_hdmi: Don't access LCDC channel in notifier callback Laurent Pinchart
@ 2011-12-13 23:02 ` Guennadi Liakhovetski
  2011-12-14 10:41 ` [PATCH 06/57] fbdev: sh_mobile_hdmi: Don't access LCDC channel in notifier callback Laurent Pinchart
  2011-12-14 10:47 ` Laurent Pinchart
  2 siblings, 0 replies; 4+ messages in thread
From: Guennadi Liakhovetski @ 2011-12-13 23:02 UTC (permalink / raw)
  To: linux-fbdev

On Tue, 13 Dec 2011, Laurent Pinchart wrote:

> Instead of relying on info->par being a pointer to an LCDC channel, cast
> the notifier block pointer to an sh_hdmi pointer.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  drivers/video/sh_mobile_hdmi.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/video/sh_mobile_hdmi.c b/drivers/video/sh_mobile_hdmi.c
> index 647ba98..b1e90f5 100644
> --- a/drivers/video/sh_mobile_hdmi.c
> +++ b/drivers/video/sh_mobile_hdmi.c
> @@ -225,6 +225,8 @@ struct sh_hdmi {
>  	struct notifier_block notifier;
>  };
>  
> +#define notifier_to_hdmi(n)	container_of(n, struct sh_hdmi, notifier)
> +
>  static void hdmi_write(struct sh_hdmi *hdmi, u8 data, u8 reg)
>  {
>  	iowrite8(data, hdmi->base + reg);
> @@ -1204,9 +1206,7 @@ static int sh_hdmi_notify(struct notifier_block *nb,
>  {
>  	struct fb_event *event = data;
>  	struct fb_info *info = event->info;
> -	struct sh_mobile_lcdc_chan *ch = info->par;
> -	struct sh_mobile_lcdc_board_cfg	*board_cfg = &ch->cfg.board_cfg;
> -	struct sh_hdmi *hdmi = board_cfg->board_data;
> +	struct sh_hdmi *hdmi = notifier_to_hdmi(nb);
>  
>  	if (!hdmi || nb != &hdmi->notifier || hdmi->info != info)

Then you also can drop the first two of the three checks above. If I'm not 
mistaken, in a HDMI / LCD set up, if this notifier is called for the LCD 
panel, hdmi will wtill point to the HDMI-related sh_hdmi object, whose 
->info will then mismatch the info pointer, derived from the notifier 
"data" pointer.

>  		return NOTIFY_DONE;
> -- 
> 1.7.3.4

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 06/57] fbdev: sh_mobile_hdmi: Don't access LCDC channel in notifier callback
  2011-12-13 14:02 [PATCH 06/57] fbdev: sh_mobile_hdmi: Don't access LCDC channel in notifier callback Laurent Pinchart
  2011-12-13 23:02 ` [PATCH 06/57] fbdev: sh_mobile_hdmi: Don't access LCDC channel Guennadi Liakhovetski
@ 2011-12-14 10:41 ` Laurent Pinchart
  2011-12-14 10:47 ` Laurent Pinchart
  2 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2011-12-14 10:41 UTC (permalink / raw)
  To: linux-fbdev

On Wednesday 14 December 2011 00:02:11 Guennadi Liakhovetski wrote:
> On Tue, 13 Dec 2011, Laurent Pinchart wrote:
> > Instead of relying on info->par being a pointer to an LCDC channel, cast
> > the notifier block pointer to an sh_hdmi pointer.
> > 
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > 
> >  drivers/video/sh_mobile_hdmi.c |    6 +++---
> >  1 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/video/sh_mobile_hdmi.c
> > b/drivers/video/sh_mobile_hdmi.c index 647ba98..b1e90f5 100644
> > --- a/drivers/video/sh_mobile_hdmi.c
> > +++ b/drivers/video/sh_mobile_hdmi.c
> > @@ -225,6 +225,8 @@ struct sh_hdmi {
> > 
> >  	struct notifier_block notifier;
> >  
> >  };
> > 
> > +#define notifier_to_hdmi(n)	container_of(n, struct sh_hdmi, notifier)
> > +
> > 
> >  static void hdmi_write(struct sh_hdmi *hdmi, u8 data, u8 reg)
> >  {
> >  
> >  	iowrite8(data, hdmi->base + reg);
> > 
> > @@ -1204,9 +1206,7 @@ static int sh_hdmi_notify(struct notifier_block
> > *nb,
> > 
> >  {
> >  
> >  	struct fb_event *event = data;
> >  	struct fb_info *info = event->info;
> > 
> > -	struct sh_mobile_lcdc_chan *ch = info->par;
> > -	struct sh_mobile_lcdc_board_cfg	*board_cfg = &ch->cfg.board_cfg;
> > -	struct sh_hdmi *hdmi = board_cfg->board_data;
> > +	struct sh_hdmi *hdmi = notifier_to_hdmi(nb);
> > 
> >  	if (!hdmi || nb != &hdmi->notifier || hdmi->info != info)
> 
> Then you also can drop the first two of the three checks above. If I'm not
> mistaken, in a HDMI / LCD set up, if this notifier is called for the LCD
> panel, hdmi will wtill point to the HDMI-related sh_hdmi object, whose
> ->info will then mismatch the info pointer, derived from the notifier
> "data" pointer.
> 
> >  		return NOTIFY_DONE;
> 
> Thanks
> Guennadi
> ---
> Guennadi Liakhovetski, Ph.D.
> Freelance Open-Source Software Developer
> http://www.open-technology.de/

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 06/57] fbdev: sh_mobile_hdmi: Don't access LCDC channel in notifier callback
  2011-12-13 14:02 [PATCH 06/57] fbdev: sh_mobile_hdmi: Don't access LCDC channel in notifier callback Laurent Pinchart
  2011-12-13 23:02 ` [PATCH 06/57] fbdev: sh_mobile_hdmi: Don't access LCDC channel Guennadi Liakhovetski
  2011-12-14 10:41 ` [PATCH 06/57] fbdev: sh_mobile_hdmi: Don't access LCDC channel in notifier callback Laurent Pinchart
@ 2011-12-14 10:47 ` Laurent Pinchart
  2 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2011-12-14 10:47 UTC (permalink / raw)
  To: linux-fbdev

Hi Guennadi,

On Wednesday 14 December 2011 00:02:11 Guennadi Liakhovetski wrote:
> On Tue, 13 Dec 2011, Laurent Pinchart wrote:
> > Instead of relying on info->par being a pointer to an LCDC channel, cast
> > the notifier block pointer to an sh_hdmi pointer.
> > 
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > 
> >  drivers/video/sh_mobile_hdmi.c |    6 +++---
> >  1 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/video/sh_mobile_hdmi.c
> > b/drivers/video/sh_mobile_hdmi.c index 647ba98..b1e90f5 100644
> > --- a/drivers/video/sh_mobile_hdmi.c
> > +++ b/drivers/video/sh_mobile_hdmi.c
> > @@ -225,6 +225,8 @@ struct sh_hdmi {
> > 
> >  	struct notifier_block notifier;
> >  
> >  };
> > 
> > +#define notifier_to_hdmi(n)	container_of(n, struct sh_hdmi, notifier)
> > +
> > 
> >  static void hdmi_write(struct sh_hdmi *hdmi, u8 data, u8 reg)
> >  {
> >  
> >  	iowrite8(data, hdmi->base + reg);
> > 
> > @@ -1204,9 +1206,7 @@ static int sh_hdmi_notify(struct notifier_block
> > *nb,
> > 
> >  {
> >  
> >  	struct fb_event *event = data;
> >  	struct fb_info *info = event->info;
> > 
> > -	struct sh_mobile_lcdc_chan *ch = info->par;
> > -	struct sh_mobile_lcdc_board_cfg	*board_cfg = &ch->cfg.board_cfg;
> > -	struct sh_hdmi *hdmi = board_cfg->board_data;
> > +	struct sh_hdmi *hdmi = notifier_to_hdmi(nb);
> > 
> >  	if (!hdmi || nb != &hdmi->notifier || hdmi->info != info)
> 
> Then you also can drop the first two of the three checks above. If I'm not
> mistaken, in a HDMI / LCD set up, if this notifier is called for the LCD
> panel, hdmi will wtill point to the HDMI-related sh_hdmi object, whose
> ->info will then mismatch the info pointer, derived from the notifier
> "data" pointer.

That's correct. The first two checks don't hurt, but will always be false. 
I'll remove them.

> >  		return NOTIFY_DONE;

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-12-14 10:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-13 14:02 [PATCH 06/57] fbdev: sh_mobile_hdmi: Don't access LCDC channel in notifier callback Laurent Pinchart
2011-12-13 23:02 ` [PATCH 06/57] fbdev: sh_mobile_hdmi: Don't access LCDC channel Guennadi Liakhovetski
2011-12-14 10:41 ` [PATCH 06/57] fbdev: sh_mobile_hdmi: Don't access LCDC channel in notifier callback Laurent Pinchart
2011-12-14 10:47 ` Laurent Pinchart

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).