From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Date: Wed, 08 Feb 2012 18:36:07 +0000 Subject: Re: [PATCH 02/16] ARM: omap: fix oops in drivers/video/omap2/dss/dpi.c Message-Id: <20120208183607.GB29796@atomide.com> List-Id: References: <20120208163546.GA15849@n2100.arm.linux.org.uk> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Russell King - ARM Linux Cc: linux-omap@vger.kernel.org, Tomi Valkeinen , Florian Tobias Schandinat , linux-fbdev@vger.kernel.org * Russell King - ARM Linux [120208 08:05]: > When a PMIC is not found, this driver is unable to obtain its > 'vdds_dsi_reg' regulator. Even through its initialization function > fails, other code still calls its enable function, which fails to > check whether it has this regulator before asking for it to be enabled. > > This fixes the oops, however a better fix would be to sort out the > upper layers to prevent them calling into a module which failed to > initialize. > > Signed-off-by: Russell King Tomi can look into fixing this properly for v3.4: Acked-by: Tony Lindgren