OMAP DSS warning in apply.c

OMAP DSS warning in apply.c

[Russell King - ARM Linux]

kautobuildv2 discovered this in its omap4430sdp oldconfig build:

drivers/video/omap2/dss/apply.c:350: warning: 'wait_pending_extra_info_updates' defined but not used

This looks like a valid warning, because wait_pending_extra_info_updates()
seems to be completely unreferenced.  Should the function be removed?
It looks like extra_updated_completion can also be removed as well, as
that function is the only place it gets initialized and waited for.

The function also looks weird - it calls extra_info_update_ongoing() first
under a lock, and then outside the lock.  It's not particularly nice API
wise to have stuff sometimes called under a lock and sometimes not.

Re: OMAP DSS warning in apply.c

[Cousson, Benoit]

+ Tomi

On 2/14/2012 1:06 PM, Russell King - ARM Linux wrote:
> kautobuildv2 discovered this in its omap4430sdp oldconfig build:
>
> drivers/video/omap2/dss/apply.c:350: warning: 'wait_pending_extra_info_updates' defined but not used
>
> This looks like a valid warning, because wait_pending_extra_info_updates()
> seems to be completely unreferenced.  Should the function be removed?
> It looks like extra_updated_completion can also be removed as well, as
> that function is the only place it gets initialized and waited for.
>
> The function also looks weird - it calls extra_info_update_ongoing() first
> under a lock, and then outside the lock.  It's not particularly nice API
> wise to have stuff sometimes called under a lock and sometimes not.

Re: OMAP DSS warning in apply.c

[Tomi Valkeinen]

[-- Attachment #1: Type: text/plain, Size: 1375 bytes --]

On Tue, 2012-02-14 at 12:06 +0000, Russell King - ARM Linux wrote:
> kautobuildv2 discovered this in its omap4430sdp oldconfig build:
> 
> drivers/video/omap2/dss/apply.c:350: warning: 'wait_pending_extra_info_updates' defined but not used
> 
> This looks like a valid warning, because wait_pending_extra_info_updates()
> seems to be completely unreferenced.  Should the function be removed?
> It looks like extra_updated_completion can also be removed as well, as
> that function is the only place it gets initialized and waited for.

The function will be used when the fifo merge series goes in in the next
merge window.

I added the "extra_info" code before fifo merge, as it's will be used by
the fifo merge code and it kinda belonged with the other apply stuff.

The fifo merge code was also supposed to go in in the previous merge
window with the rest of the rewrites, but due to some complications it
was delayed and missed the merge window.

> The function also looks weird - it calls extra_info_update_ongoing() first
> under a lock, and then outside the lock.  It's not particularly nice API
> wise to have stuff sometimes called under a lock and sometimes not.

The second call is actually extra, it was just added for verification
purposes during development to ensure that the wait logic works
correctly.

I'll remove it.

 Tomi


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]