From: Tony Lindgren <tony@atomide.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-fbdev@vger.kernel.org, archit@ti.com, linux-omap@vger.kernel.org
Subject: Re: [PATCH 00/16] OMAPDSS: old OMAPFB cleanup
Date: Wed, 22 Feb 2012 18:50:16 +0000 [thread overview]
Message-ID: <20120222185016.GI18185@atomide.com> (raw)
In-Reply-To: <1329220343.1845.65.camel@deskari>
* Tomi Valkeinen <tomi.valkeinen@ti.com> [120214 03:21]:
> Hi Tony,
>
> On Tue, 2012-01-24 at 12:00 +0200, Tomi Valkeinen wrote:
> > Now that all omap2+ boards have been changed to use the newer omapdss driver,
> > this patch series removes omap2+ support from the old omapfb driver
> > (drivers/video/omap), and thus makes it an omap1 dss/fb driver.
> >
> > The use of SRAM for video ram had earlier been disabled by removing the SRAM
> > allocation (fee926bb0d399b1eaaf38f9f694bbf2747c4b8a2), and now this series also
> > removes the support from the omap fb drivers.
> >
> > Also various cleanup patches allow us to remove remove OMAP_TAG_LCD and
> > OMAP_TAG_FBMEM.
> >
> > All in all, the series removes quite a bit of unneeded code and cleans up the
> > links between the board files and the display drivers, and this should help
> > with device tree adaptation.
Great, looks good to me. I've acked the arch/arm/*omap*/* patches.
There may be some trivial merge conflicts with the includes with
my cleanup branch for the io.h changes.
> > Some of the patches affect the newer omapdss and omapfb drivers, but mostly the
> > patches deal with omap1. I have compile tested the series for both omap1 and
> > omap2, but I have only tested this on OMAP3 and OMAP4 boards, as I don't have
> > OMAP1/2 boards. I think N770's display won't work after these patches, but
> > other OMAP1 boards should be ok. To fix N770's display requires knowledge of
> > the hardware setup, which is currently passed from the bootloader.
>
> Tony, do you have any feedback on this? I think the arch/arm changes are
> quite clean as such, but are you ok with (possibly) breaking N770's
> display? The other OMAP1 boards should, at least in theory, work as well
> as before.
>
> For N770, the bootloader passes the reset GPIO number and number of
> datalines, and I have no idea what those are.
I think they should be:
conf->nreset_gpio = 13
conf->data_lines = 24
Regards,
Tony
next prev parent reply other threads:[~2012-02-22 18:50 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 10:00 [PATCH 00/16] OMAPDSS: old OMAPFB cleanup Tomi Valkeinen
2012-01-24 10:00 ` [PATCH 01/16] OMAPFB: remove old blizzard driver Tomi Valkeinen
2012-01-24 10:00 ` =?UTF-8?q?=5BPATCH=2002/16=5D=20OMAPFB=3A=20Remove=20OMAP2/3=20support=20from=20old=20omapfb=20drive Tomi Valkeinen
2012-01-24 10:00 ` [PATCH 03/16] OMAPDSS: Remove video SRAM support Tomi Valkeinen
2012-02-22 18:06 ` Tony Lindgren
2012-01-24 10:00 ` [PATCH 04/16] OMAPFB: Remove video SRAM support (old omapfb) Tomi Valkeinen
2012-02-22 18:06 ` Tony Lindgren
2012-01-24 10:00 ` [PATCH 05/16] OMAP2+: remove unneeded #include omapfb.h Tomi Valkeinen
2012-02-22 18:07 ` Tony Lindgren
2012-01-24 10:00 ` [PATCH 06/16] OMAP: N770: remove HWA742 platform data Tomi Valkeinen
2012-02-22 18:08 ` Tony Lindgren
2012-01-24 10:00 ` [PATCH 07/16] OAMPFB: remove unused omapfb_set_ctrl_platform_data() Tomi Valkeinen
2012-02-22 18:08 ` Tony Lindgren
2012-01-24 10:00 ` [PATCH 08/16] OMAPFB: remove early mem alloc from old omapfb Tomi Valkeinen
2012-02-22 18:09 ` Tony Lindgren
2012-01-24 10:00 ` [PATCH 09/16] OMAPFB: remove mem info from platform_data Tomi Valkeinen
2012-01-24 10:00 ` [PATCH 10/16] OMAPFB: remove unused fb_format_to_dss_mode() Tomi Valkeinen
2012-01-24 10:00 ` [PATCH 11/16] OMAPFB: Move old omapfb private structs to a private include file Tomi Valkeinen
2012-01-24 10:00 ` [PATCH 12/16] OMAPFB: remove omapfb_set_platform_data() Tomi Valkeinen
2012-02-22 18:09 ` Tony Lindgren
2012-01-24 10:00 ` [PATCH 13/16] OMAP1: pass LCD config with omapfb_set_lcd_config() Tomi Valkeinen
2012-02-22 18:10 ` Tony Lindgren
2012-01-24 10:00 ` [PATCH 14/16] OMAP: Remove OMAP_TAG_LCD and OMAP_TAG_FBMEM Tomi Valkeinen
2012-02-22 18:11 ` Tony Lindgren
2012-01-24 10:00 ` [PATCH 15/16] OMAP1: Remove unused LCD devices from board files Tomi Valkeinen
2012-02-22 18:11 ` Tony Lindgren
2012-01-24 10:00 ` [PATCH 16/16] OMAPFB: remove remaining OMAP arch checks Tomi Valkeinen
2012-02-22 18:11 ` Tony Lindgren
2012-02-14 11:52 ` [PATCH 00/16] OMAPDSS: old OMAPFB cleanup Tomi Valkeinen
2012-02-22 18:50 ` Tony Lindgren [this message]
2012-02-22 22:09 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120222185016.GI18185@atomide.com \
--to=tony@atomide.com \
--cc=archit@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).