From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: santosh nayak <santoshprasadnayak@gmail.com>
Cc: FlorianSchandinat@gmx.de, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Video : Amba: Use in_interrupt() in clcdfb_sleep().
Date: Sun, 11 Mar 2012 13:27:46 +0000 [thread overview]
Message-ID: <20120311132746.GA13336@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1331471665-22226-1-git-send-email-santoshprasadnayak@gmail.com>
On Sun, Mar 11, 2012 at 06:44:25PM +0530, santosh nayak wrote:
> From: Santosh Nayak <santoshprasadnayak@gmail.com>
>
> Instead of "in_atomic()", we can use in_interrupt() to check whether
> its an interrupt context.
What are you trying to fix?
Your description is an example of a bad commit comment. It merely
describes the change, which anyone can see by looking at the diff.
What it totally and utterly fails to do is to describe _why_ the
change is necessary or what the problem is.
So, until it does, this patch gets a definite NAK.
next prev parent reply other threads:[~2012-03-11 13:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-11 13:26 [PATCH] Video : Amba: Use in_interrupt() in clcdfb_sleep() santosh nayak
2012-03-11 13:22 ` richard -rw- weinberger
2012-03-11 13:27 ` Russell King - ARM Linux [this message]
2012-03-11 14:29 ` santosh prasad nayak
2012-03-11 14:36 ` Russell King - ARM Linux
2012-03-11 14:49 ` santosh prasad nayak
2012-03-11 15:03 ` Russell King - ARM Linux
2012-03-11 15:31 ` santosh prasad nayak
2012-03-11 15:48 ` Russell King - ARM Linux
2012-03-11 16:49 ` santosh prasad nayak
2012-03-11 16:42 ` Russell King - ARM Linux
2012-03-11 16:58 ` santosh prasad nayak
2012-03-11 17:05 ` Russell King - ARM Linux
2012-03-11 18:24 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120311132746.GA13336@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=FlorianSchandinat@gmx.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=santoshprasadnayak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).