linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Pradeep Subrahmanion <subrahmanion.pradeep@gmail.com>
Cc: rpurdie@rpsys.net, FlorianSchandinat@gmx.de,
	akpm@linux-foundation.org, linux-fbdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Added backlight driver for Acer Aspire 4736
Date: Mon, 12 Mar 2012 17:51:30 +0000	[thread overview]
Message-ID: <20120312175130.GA18002@srcf.ucam.org> (raw)
In-Reply-To: <1331608337.2267.67.camel@debian.Gayathri>

On Mon, Mar 12, 2012 at 11:12:17PM -0400, Pradeep Subrahmanion wrote:
> Hi ,
> 
>   Brightness control was not  working on Acer Aspire 4736 using default ACPI interface.  acer-acpi also do not support 4730 series since it uses new WMI interface.
> This driver adds brightness control by accessing the LBB PCI configuration register. This approach may also work on other laptops in 4730 series .But currently ,  it is only tested  for 
> Aspire 4736. 

1) If there's a WMI interface to brightness control, why not use that?
2) You're hitting a hardware resource that belongs to the i915 driver, 
which may well cause problems.
3) Why does the ACPI interface not work? Can you attach the acpidump 
output?

-- 
Matthew Garrett | mjg59@srcf.ucam.org

  reply	other threads:[~2012-03-12 17:51 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CABNxG=CU+bOWUauLYfcS2vtFqKvXA-9axgokNoYz+KuU1Mzztw@mail.gmail.com>
2012-03-11 19:42 ` [PATCH] Added backlight driver for Acer Aspire 4736 Florian Tobias Schandinat
2012-03-12 17:36   ` Pradeep Subrahmanion
2012-03-12 17:51     ` Matthew Garrett [this message]
     [not found]       ` <1331640592.3485.50.camel@debian.Gayathri>
2012-03-13 12:47         ` Matthew Garrett
     [not found]           ` <CABNxG=Dqg26EHmC3vibf3-SjVhby1qgQfMniQObUeh9eJ6SwEw@mail.gmail.com>
2012-03-13 13:34             ` Matthew Garrett
2012-03-13 15:49               ` Pradeep Subrahmanion
2012-03-13 23:12                 ` joeyli
2012-03-14  2:55                   ` Pradeep Subrahmanion
2012-03-14  5:51                     ` joeyli
2012-03-14  6:29                       ` Pradeep Subrahmanion
2012-03-15  8:05                         ` joeyli
2012-03-18  5:22                           ` Pradeep Subrahmanion
2012-03-19  2:01                             ` joeyli
2012-03-19 11:45                               ` Pradeep Subrahmanion
2012-03-20  3:55                                 ` joeyli
2012-03-20 11:09                               ` joeyli
2012-03-20 18:55                                 ` Pradeep Subrahmanion
2012-03-21  3:00                                   ` joeyli
2012-03-21 19:21                                     ` Pradeep Subrahmanion
2012-03-22  1:33                                       ` joeyli
2012-03-22  2:45                                         ` Pradeep Subrahmanion
2012-03-22  3:25                                           ` joeyli
2012-03-22  3:44                                             ` Pradeep Subrahmanion
2012-03-22  3:54                                               ` joeyli
2012-03-22  5:57                                                 ` Pradeep Subrahmanion
2012-03-22  9:34                                                   ` joeyli
2012-03-22 16:29                                                     ` Pradeep Subrahmanion
2012-03-23  3:48                                     ` Pradeep Subrahmanion
2012-03-23  4:25                                       ` joeyli
2012-03-18  5:24                           ` Pradeep Subrahmanion
2012-03-13 13:41           ` Pradeep Subrahmanion
2012-03-12 23:07     ` Joe Perches
2012-03-12 17:40   ` Pradeep Subrahmanion
2012-03-13  3:10   ` joeyli
     [not found]     ` <1331644360.3319.6.camel@debian.Gayathri>
2012-03-13  4:35       ` joeyli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120312175130.GA18002@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=FlorianSchandinat@gmx.de \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    --cc=subrahmanion.pradeep@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).