[PATCH 1/2] video: msm: Fix section mismatches in mddi.c

[PATCH 1/2] video: msm: Fix section mismatches in mddi.c

[David Brown]

The change
    commit 461cbe77d0a4f887c33a3a95ea68a7daf23b4302
    Author: Gregory Bean <gbean@codeaurora.org>
    Date:   Wed Jul 28 10:22:13 2010 -0700

        video: msm: Fix section mismatch in mddi.c.

fixes a section mismatch between the board file and the driver's probe
function, however, it misses the additional mismatches between the
probe function and some routines it calls.  Fix these up as well.

Signed-off-by: David Brown <davidb@codeaurora.org>
---
 drivers/video/msm/mddi.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/video/msm/mddi.c b/drivers/video/msm/mddi.c
index 4527cbf..b061d70 100644
--- a/drivers/video/msm/mddi.c
+++ b/drivers/video/msm/mddi.c
@@ -420,7 +420,7 @@ static void mddi_resume(struct msm_mddi_client_data *cdata)
 	mddi_set_auto_hibernate(&mddi->client_data, 1);
 }
 
-static int __init mddi_get_client_caps(struct mddi_info *mddi)
+static int __devinit mddi_get_client_caps(struct mddi_info *mddi)
 {
 	int i, j;
 
@@ -622,9 +622,9 @@ uint32_t mddi_remote_read(struct msm_mddi_client_data *cdata, uint32_t reg)
 
 static struct mddi_info mddi_info[2];
 
-static int __init mddi_clk_setup(struct platform_device *pdev,
-				 struct mddi_info *mddi,
-				 unsigned long clk_rate)
+static int __devinit mddi_clk_setup(struct platform_device *pdev,
+				    struct mddi_info *mddi,
+				    unsigned long clk_rate)
 {
 	int ret;
 
-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

Re: [PATCH 1/2] video: msm: Fix section mismatches in mddi.c

[Florian Tobias Schandinat]

On 04/12/2012 06:45 PM, David Brown wrote:
> The change
>     commit 461cbe77d0a4f887c33a3a95ea68a7daf23b4302
>     Author: Gregory Bean <gbean@codeaurora.org>
>     Date:   Wed Jul 28 10:22:13 2010 -0700
> 
>         video: msm: Fix section mismatch in mddi.c.
> 
> fixes a section mismatch between the board file and the driver's probe
> function, however, it misses the additional mismatches between the
> probe function and some routines it calls.  Fix these up as well.
> 
> Signed-off-by: David Brown <davidb@codeaurora.org>

Applied.


Thanks,

Florian Tobias Schandinat

> ---
>  drivers/video/msm/mddi.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/video/msm/mddi.c b/drivers/video/msm/mddi.c
> index 4527cbf..b061d70 100644
> --- a/drivers/video/msm/mddi.c
> +++ b/drivers/video/msm/mddi.c
> @@ -420,7 +420,7 @@ static void mddi_resume(struct msm_mddi_client_data *cdata)
>  	mddi_set_auto_hibernate(&mddi->client_data, 1);
>  }
>  
> -static int __init mddi_get_client_caps(struct mddi_info *mddi)
> +static int __devinit mddi_get_client_caps(struct mddi_info *mddi)
>  {
>  	int i, j;
>  
> @@ -622,9 +622,9 @@ uint32_t mddi_remote_read(struct msm_mddi_client_data *cdata, uint32_t reg)
>  
>  static struct mddi_info mddi_info[2];
>  
> -static int __init mddi_clk_setup(struct platform_device *pdev,
> -				 struct mddi_info *mddi,
> -				 unsigned long clk_rate)
> +static int __devinit mddi_clk_setup(struct platform_device *pdev,
> +				    struct mddi_info *mddi,
> +				    unsigned long clk_rate)
>  {
>  	int ret;
>  

Re: [PATCH 1/2] video: msm: Fix section mismatches in mddi.c

[David Brown]

On Mon, Apr 23, 2012 at 06:16:55AM +0000, Florian Tobias Schandinat wrote:
> On 04/12/2012 06:45 PM, David Brown wrote:
> > The change
> >     commit 461cbe77d0a4f887c33a3a95ea68a7daf23b4302
> >     Author: Gregory Bean <gbean@codeaurora.org>
> >     Date:   Wed Jul 28 10:22:13 2010 -0700
> > 
> >         video: msm: Fix section mismatch in mddi.c.
> > 
> > fixes a section mismatch between the board file and the driver's probe
> > function, however, it misses the additional mismatches between the
> > probe function and some routines it calls.  Fix these up as well.
> > 
> > Signed-off-by: David Brown <davidb@codeaurora.org>
> 
> Applied.

Hmm.  I guess it is somewhat my fault, since I sent the message To
both myself and you.  I've already applied this to the MSM tree, and I
believe it has been merged into Linus' tree.  I don't think it'll be
an issue, since git merge will handle the duplicate patch fine.

Next time, I'll try to be clearer about which tree I'm thinking for a
patch to go through.

David

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.