* [PATCH] video: mb862xx-i2c: local functions should not be exposed globally
@ 2012-05-03 0:34 H Hartley Sweeten
2012-05-10 0:12 ` Florian Tobias Schandinat
0 siblings, 1 reply; 2+ messages in thread
From: H Hartley Sweeten @ 2012-05-03 0:34 UTC (permalink / raw)
To: Linux Kernel; +Cc: linux-fbdev, FlorianSchandinat, agust
Functions not referenced outside of a source file should be marked
static to prevent them from being exposed globally.
Quiets the sparse warnings:
warning: symbol 'mb862xx_i2c_stop' was not declared. Should it be static?
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Cc: Anatolij Gustschin <agust@denx.de>
---
diff --git a/drivers/video/mb862xx/mb862xx-i2c.c b/drivers/video/mb862xx/mb862xx-i2c.c
index 273769b..c87e17a 100644
--- a/drivers/video/mb862xx/mb862xx-i2c.c
+++ b/drivers/video/mb862xx/mb862xx-i2c.c
@@ -68,7 +68,7 @@ static int mb862xx_i2c_read_byte(struct i2c_adapter *adap, u8 *byte, int last)
return 1;
}
-void mb862xx_i2c_stop(struct i2c_adapter *adap)
+static void mb862xx_i2c_stop(struct i2c_adapter *adap)
{
struct mb862xxfb_par *par = adap->algo_data;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video: mb862xx-i2c: local functions should not be exposed globally
2012-05-03 0:34 [PATCH] video: mb862xx-i2c: local functions should not be exposed globally H Hartley Sweeten
@ 2012-05-10 0:12 ` Florian Tobias Schandinat
0 siblings, 0 replies; 2+ messages in thread
From: Florian Tobias Schandinat @ 2012-05-10 0:12 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: Linux Kernel, linux-fbdev, agust
On 05/03/2012 12:34 AM, H Hartley Sweeten wrote:
> Functions not referenced outside of a source file should be marked
> static to prevent them from being exposed globally.
>
> Quiets the sparse warnings:
>
> warning: symbol 'mb862xx_i2c_stop' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
> Cc: Anatolij Gustschin <agust@denx.de>
Applied.
Thanks,
Florian Tobias Schandinat
>
> ---
>
> diff --git a/drivers/video/mb862xx/mb862xx-i2c.c b/drivers/video/mb862xx/mb862xx-i2c.c
> index 273769b..c87e17a 100644
> --- a/drivers/video/mb862xx/mb862xx-i2c.c
> +++ b/drivers/video/mb862xx/mb862xx-i2c.c
> @@ -68,7 +68,7 @@ static int mb862xx_i2c_read_byte(struct i2c_adapter *adap, u8 *byte, int last)
> return 1;
> }
>
> -void mb862xx_i2c_stop(struct i2c_adapter *adap)
> +static void mb862xx_i2c_stop(struct i2c_adapter *adap)
> {
> struct mb862xxfb_par *par = adap->algo_data;
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-10 0:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-03 0:34 [PATCH] video: mb862xx-i2c: local functions should not be exposed globally H Hartley Sweeten
2012-05-10 0:12 ` Florian Tobias Schandinat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).