From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Date: Tue, 08 May 2012 11:31:01 +0000 Subject: Re: [PATCH] i2c: Split I2C_M_NOSTART support out of I2C_FUNC_PROTOCOL_MANGLING Message-Id: <20120508133101.5019b934@endymion.delvare> List-Id: References: <1336127208-17951-1-git-send-email-broonie@opensource.wolfsonmicro.com> In-Reply-To: <1336127208-17951-1-git-send-email-broonie@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mark Brown Cc: Florian Tobias Schandinat , Dmitry Torokhov , Wolfram Sang , linux-i2c@vger.kernel.org, linux-input@vger.kernel.org, linux-fbdev@vger.kernel.org On Fri, 4 May 2012 11:26:48 +0100, Mark Brown wrote: > Since there are uses for I2C_M_NOSTART which are much more sensible and > standard than most of the protocol mangling functionality (the main one > being gather writes to devices where something like a register address > needs to be inserted before a block of data) create a new I2C_FUNC_NOSTART > for this feature and update all the users to use it. > > Also strengthen the disrecommendation of the protocol mangling while we're > at it. > > In the case of regmap-i2c we remove the requirement for mangling as > I2C_M_NOSTART is the only mangling feature which is being used. > > Signed-off-by: Mark Brown > --- > Documentation/i2c/functionality | 8 +++++--- > Documentation/i2c/i2c-protocol | 9 ++++++++- > drivers/base/regmap/regmap-i2c.c | 2 +- > drivers/i2c/algos/i2c-algo-bit.c | 2 +- > drivers/i2c/busses/i2c-nuc900.c | 3 ++- > drivers/i2c/busses/i2c-s3c2410.c | 3 ++- > drivers/input/joystick/as5011.c | 1 + > drivers/video/matrox/matroxfb_maven.c | 1 + > include/linux/i2c.h | 5 +++-- > 9 files changed, 24 insertions(+), 10 deletions(-) > (...) Applied with minor cleanups, thanks. -- Jean Delvare