From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Date: Wed, 09 May 2012 23:37:46 +0000 Subject: Re: [PATCH] OMAPDSS: TFP410: use gpio_set_value_cansleep Message-Id: <20120509233745.GZ5088@atomide.com> List-Id: References: <1336601288-27848-1-git-send-email-Russ.Dill@ti.com> <20120509221447.GY5088@atomide.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Russ Dill Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, Tomi Valkeinen * Russ Dill [120509 15:53]: > On Wed, May 9, 2012 at 3:14 PM, Tony Lindgren wrote: > > * Russ Dill [120509 15:12]: > >> The Beagleboard xM gpio used for TFP410 powerdown is connected through > >> an I2C attached chip which means setting the GPIO can sleep. Code that > >> calls tfp410_power_on/off holds a mutex, so sleeping should be fine. > > > > What's the error without this patch? Or just no display? > > > > Just wondering if it's safe to merge Tomi's clean up series to > > arm-soc tree.. > > The only platform that has a problem is Beagleboard xM, and that is > only after 'ARM: OMAP: Cleanup Beagleboard DVI reset gpio' is applied. > Since the context actually can sleep, the only consequence is a > WARN_ON statement. > > So yes, it should be safe. Well since I have not actually merged it with other branches yet, I'll wait for Tomi to apply that and repull his for-l-o-3.5 branch. Tony