From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] mx3fb: do not support panning with fb blanked
Date: Mon, 11 Jun 2012 09:51:02 +0000 [thread overview]
Message-ID: <20120611095102.GD11168@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1339376810-8247-1-git-send-email-Ying.Liu@freescale.com>
On Mon, Jun 11, 2012 at 09:06:48AM +0800, Liu Ying wrote:
> This patch checks if framebuffer is unblanked before
> we actually trigger panning in custom pan display
> function.
>
> Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
> ---
> drivers/video/mx3fb.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/video/mx3fb.c b/drivers/video/mx3fb.c
> index e3406ab..d53db60 100644
> --- a/drivers/video/mx3fb.c
> +++ b/drivers/video/mx3fb.c
> @@ -1063,6 +1063,11 @@ static int mx3fb_pan_display(struct fb_var_screeninfo *var,
> dev_dbg(fbi->device, "%s [%c]\n", __func__,
> list_empty(&mx3_fbi->idmac_channel->queue) ? '-' : '+');
>
> + if (mx3_fbi->blank != FB_BLANK_UNBLANK) {
> + dev_dbg(fbi->device, "panning with fb blanked not supported\n");
> + return -EFAULT;
> + }
Why is this an error, and why return -EFAULT? What userspace access
failed?
next prev parent reply other threads:[~2012-06-11 9:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 1:06 [PATCH 1/3] mx3fb: do not support panning with fb blanked Liu Ying
2012-06-11 1:06 ` [PATCH 2/3] mx3fb: support pan display with fb_set_var Liu Ying
2012-07-02 6:28 ` Florian Tobias Schandinat
2012-06-11 1:06 ` [PATCH 3/3] mx3fb: avoid screen flash when panning " Liu Ying
2012-07-02 2:18 ` Liu Ying
2012-06-11 9:51 ` Russell King - ARM Linux [this message]
2012-06-11 10:46 ` [PATCH 1/3] mx3fb: do not support panning with fb blanked Liu Ying
2012-06-11 11:05 ` Russell King - ARM Linux
2012-06-11 11:18 ` Liu Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120611095102.GD11168@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).