* [PATCH] Fix newport con crashes
@ 2012-07-30 10:54 Thomas Bogendoerfer
2012-07-30 13:34 ` Ralf Baechle
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Bogendoerfer @ 2012-07-30 10:54 UTC (permalink / raw)
To: linux-mips, linux-fbdev; +Cc: ralf, FlorianSchandinat
Because of commit e84de0c61905030a0fe66b7210b6f1bb7c3e1eab
[MIPS: GIO bus support for SGI IP22/28] newport con is now taking over
console from dummy con, therefore it's necessary to resize the VC to
the correct size to avoid crashes and garbage on console
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
---
drivers/video/console/newport_con.c | 11 +++++++++--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/video/console/newport_con.c b/drivers/video/console/newport_con.c
index 6d15966..b05afd0 100644
--- a/drivers/video/console/newport_con.c
+++ b/drivers/video/console/newport_con.c
@@ -327,9 +327,16 @@ out_unmap:
static void newport_init(struct vc_data *vc, int init)
{
- vc->vc_cols = newport_xsize / 8;
- vc->vc_rows = newport_ysize / 16;
+ int cols, rows;
+
+ cols = newport_xsize / 8;
+ rows = newport_ysize / 16;
vc->vc_can_do_color = 1;
+ if (init) {
+ vc->vc_cols = cols;
+ vc->vc_rows = rows;
+ } else
+ vc_resize(vc, cols, rows);
}
static void newport_deinit(struct vc_data *c)
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Fix newport con crashes
2012-07-30 10:54 [PATCH] Fix newport con crashes Thomas Bogendoerfer
@ 2012-07-30 13:34 ` Ralf Baechle
2012-08-01 9:52 ` Florian Tobias Schandinat
0 siblings, 1 reply; 3+ messages in thread
From: Ralf Baechle @ 2012-07-30 13:34 UTC (permalink / raw)
To: Thomas Bogendoerfer; +Cc: linux-mips, linux-fbdev, FlorianSchandinat
On Mon, Jul 30, 2012 at 12:54:16PM +0200, Thomas Bogendoerfer wrote:
> Because of commit e84de0c61905030a0fe66b7210b6f1bb7c3e1eab
> [MIPS: GIO bus support for SGI IP22/28] newport con is now taking over
> console from dummy con, therefore it's necessary to resize the VC to
> the correct size to avoid crashes and garbage on console
>
> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
I've applied your patch to master and the affected -stable branches of the
lmo git tree.
Florian, since this is a driver specific to certain MIPS platforms I'd like
to merge it through the MIPS tree with your ack, if that's ok?
Thanks folks,
Ralf
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix newport con crashes
2012-07-30 13:34 ` Ralf Baechle
@ 2012-08-01 9:52 ` Florian Tobias Schandinat
0 siblings, 0 replies; 3+ messages in thread
From: Florian Tobias Schandinat @ 2012-08-01 9:52 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Thomas Bogendoerfer, linux-mips, linux-fbdev
On 07/30/2012 01:34 PM, Ralf Baechle wrote:
> On Mon, Jul 30, 2012 at 12:54:16PM +0200, Thomas Bogendoerfer wrote:
>
>> Because of commit e84de0c61905030a0fe66b7210b6f1bb7c3e1eab
>> [MIPS: GIO bus support for SGI IP22/28] newport con is now taking over
>> console from dummy con, therefore it's necessary to resize the VC to
>> the correct size to avoid crashes and garbage on console
>>
>> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
>
> I've applied your patch to master and the affected -stable branches of the
> lmo git tree.
>
> Florian, since this is a driver specific to certain MIPS platforms I'd like
> to merge it through the MIPS tree with your ack, if that's ok?
Yes, sounds good to me. The patch looks good.
Best regards,
Florian Tobias Schandinat
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-08-01 9:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-30 10:54 [PATCH] Fix newport con crashes Thomas Bogendoerfer
2012-07-30 13:34 ` Ralf Baechle
2012-08-01 9:52 ` Florian Tobias Schandinat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).