From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Date: Tue, 31 Jul 2012 14:13:29 +0000 Subject: Re: [RFC][PATCH v3 1/3] runtime interpreted power sequences Message-Id: <20120731141328.GS4468@opensource.wolfsonmicro.com> List-Id: References: <1343390750-3642-1-git-send-email-acourbot@nvidia.com> <1343390750-3642-2-git-send-email-acourbot@nvidia.com> <50170EA0.1010408@wwwdotorg.org> <5017B434.2010706@nvidia.com> <20120731105640.GD16155@avionic-0098.adnet.avionic-design.de> In-Reply-To: <20120731105640.GD16155-RM9K5IK7kjIyiCvfTdI0JKcOhU4Rzj621B7CTYaBSLdn68oJJulU0Q@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Thierry Reding Cc: Alex Courbot , Stephen Warren , Stephen Warren , Simon Glass , Grant Likely , Rob Herring , Greg Kroah-Hartman , Arnd Bergmann , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" On Tue, Jul 31, 2012 at 12:56:40PM +0200, Thierry Reding wrote: > On Tue, Jul 31, 2012 at 07:32:20PM +0900, Alex Courbot wrote: > > The thing is that I am not sure what happens to the platform data > > once probe() is done. Isn't it customary to mark it with __devinit > > and have it freed after probing is successful? > No, platform data should stay around forever. Otherwise, consider what > would happen if your driver is built as a module and you unload and load > it again. __devinit can be discarded if you disable enough kernel features, HOTPLUG is the main one IIRC, modules might also need to go - drivers really ought to take a copy of platform data they plan to use at runtime, though practically speaking you have to try to trigger any problems.