linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: linux-fbdev@vger.kernel.org
Subject: re: s3fb: fix up DDC build with MTRR disabled.
Date: Mon, 13 Aug 2012 16:39:08 +0000	[thread overview]
Message-ID: <20120813163908.GA18576@elgon.mountain> (raw)

[Sorry this is reall old.  I don't think I've emailed about it before]

Hello Paul Mundt,

This is a semi-automatic email about new static checker warnings.

The patch 4f2970b9f622: "s3fb: fix up DDC build with MTRR disabled." 
from Apr 20, 2011, leads to the following Smatch complaint:

drivers/video/s3fb.c:1411 s3_pci_remove()
	 warn: variable dereferenced before check 'info' (see line 1409)

drivers/video/s3fb.c
  1408		struct fb_info *info = pci_get_drvdata(dev);
  1409		struct s3fb_info __maybe_unused *par = info->par;
                                                       ^^^^^^^^^
New dereference.

  1410	
  1411		if (info) {
                    ^^^^
Old check.

  1412	
  1413	#ifdef CONFIG_MTRR

regards,
dan carpenter


                 reply	other threads:[~2012-08-13 16:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120813163908.GA18576@elgon.mountain \
    --to=dan.carpenter@oracle.com \
    --cc=linux-fbdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).