linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* re: s3fb: fix up DDC build with MTRR disabled.
@ 2012-08-13 16:39 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2012-08-13 16:39 UTC (permalink / raw)
  To: linux-fbdev

[Sorry this is reall old.  I don't think I've emailed about it before]

Hello Paul Mundt,

This is a semi-automatic email about new static checker warnings.

The patch 4f2970b9f622: "s3fb: fix up DDC build with MTRR disabled." 
from Apr 20, 2011, leads to the following Smatch complaint:

drivers/video/s3fb.c:1411 s3_pci_remove()
	 warn: variable dereferenced before check 'info' (see line 1409)

drivers/video/s3fb.c
  1408		struct fb_info *info = pci_get_drvdata(dev);
  1409		struct s3fb_info __maybe_unused *par = info->par;
                                                       ^^^^^^^^^
New dereference.

  1410	
  1411		if (info) {
                    ^^^^
Old check.

  1412	
  1413	#ifdef CONFIG_MTRR

regards,
dan carpenter


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2012-08-13 16:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-13 16:39 s3fb: fix up DDC build with MTRR disabled Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).