From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: LKML <linux-kernel@vger.kernel.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 0/2] console_lock debug improvements
Date: Wed, 22 Aug 2012 13:18:46 +0000 [thread overview]
Message-ID: <20120822141846.3b142c12@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <1345588472-4055-1-git-send-email-daniel.vetter@ffwll.ch>
On Wed, 22 Aug 2012 00:34:30 +0200
Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Hi all,
>
> After Dave Airlie blew through a few days to track down a deadlock at boot-up
> when handing over from the firmware fb to the kms/drm framebuffer driver (1), I've
> figured that lockdep /should/ have caught this.
>
> And indeed, by adding proper annotations to the console_lock it complains about
> the potential deadlock when exercising the entire driver life-cycle of just one
> fb driver (i.e. not even a handover required). While at it, I've replaced the
> existing in_interrupt check with the more paranoid might_sleep.
>
> Comments, flames and review highly welcome.
This will be an absolute godsend for DRI debugging. Definitely wants to go
in.
Alan
prev parent reply other threads:[~2012-08-22 13:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 22:34 [PATCH 0/2] console_lock debug improvements Daniel Vetter
2012-08-21 22:34 ` [PATCH 1/2] console: use might_sleep in console_lock Daniel Vetter
2012-08-21 22:34 ` [PATCH 2/2] console: implement lockdep support for console_lock Daniel Vetter
2012-08-22 13:18 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120822141846.3b142c12@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox