* Re: [PATCH 00/19] SH Mobile LCDC panel cleanup (including board code)
2012-08-16 13:00 [PATCH 00/19] SH Mobile LCDC panel cleanup (including board code) Laurent Pinchart
@ 2012-08-27 8:54 ` Simon Horman
2012-08-27 15:35 ` Laurent Pinchart
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Simon Horman @ 2012-08-27 8:54 UTC (permalink / raw)
To: linux-fbdev
On Thu, Aug 16, 2012 at 03:00:35PM +0200, Laurent Pinchart wrote:
> Hi everybody,
>
> As part of a general panel API implementation (more on that a bit later), I've
> cleaned up panel support in the LCDC driver and in the related board code. The
> result is 19 patches independent of the generic panel API that I would like to
> get reviewed by the respective board maintainers.
Hi Paul,
I'm happy for you to take all of this, including the mach-shmobile
portions through your tree if that works for you.
>
> Laurent Pinchart (19):
> fbdev: sh_mobile_lcdc: Get display dimensions from the channel
> structure
> fbdev: sh_mobile_lcdc: Rename mode argument to modes
> fbdev: sh_mobile_lcdc: Remove priv argument from channel and overlay
> init
> ARM: mach-shmobile: ag5evm: Add LCDC tx_dev field to platform data
> fbdev: sh_mipi_dsi: Add channel field to platform data
> ARM: mach-shmobile: Initiliaze the new sh_mipi_dsi_info channel field
> fbdev: sh_mipi_dsi: Use the sh_mipi_dsi_info channel field
> fbdev: sh_mipi_dsi: Use the LCDC entity default mode
> fbdev: sh_mipi_dsi: Remove last reference to LCDC platform data
> ARM: mach-shmobile: Remove the unused sh_mipi_dsi_info lcd_chan field
> fbdev: sh_mipi_dsi: Remove the unused sh_mipi_dsi_info lcd_chan field
> fbdev: sh_mobile_lcdc: Store the backlight brightness internally
> ARM: mach-shmobile: mackerel: Removed unused get_brightness callback
> sh: ap325rxa: Remove unused get_brightness LCDC callback
> sh: ecovec24: Remove unused get_brightness LCDC callback
> fbdev: sh_mobile_lcdc: Remove unused get_brightness pdata callback
> ARM: mach-shmobile: ag5evm: Use the backlight API for brightness
> control
> sh: kfr2r09: Use the backlight API for brightness control
> fbdev: sh_mobile_lcdc: Make sh_mobile_lcdc_sys_bus_ops static
>
> arch/arm/mach-shmobile/board-ag5evm.c | 198 ++++++++++++++-------------
> arch/arm/mach-shmobile/board-ap4evb.c | 4 +-
> arch/arm/mach-shmobile/board-mackerel.c | 6 -
> arch/sh/boards/mach-ap325rxa/setup.c | 6 -
> arch/sh/boards/mach-ecovec24/setup.c | 6 -
> arch/sh/boards/mach-kfr2r09/lcd_wqvga.c | 16 +--
> arch/sh/boards/mach-kfr2r09/setup.c | 7 +-
> arch/sh/include/mach-kfr2r09/mach/kfr2r09.h | 6 +-
> drivers/video/sh_mipi_dsi.c | 69 ++++------
> drivers/video/sh_mobile_lcdcfb.c | 54 ++++----
> drivers/video/sh_mobile_lcdcfb.h | 1 +
> include/video/sh_mipi_dsi.h | 4 +-
> include/video/sh_mobile_lcdc.h | 1 -
> 13 files changed, 172 insertions(+), 206 deletions(-)
>
> --
> Regards,
>
> Laurent Pinchart
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 00/19] SH Mobile LCDC panel cleanup (including board code)
2012-08-16 13:00 [PATCH 00/19] SH Mobile LCDC panel cleanup (including board code) Laurent Pinchart
2012-08-27 8:54 ` Simon Horman
@ 2012-08-27 15:35 ` Laurent Pinchart
2012-08-29 6:07 ` Simon Horman
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Laurent Pinchart @ 2012-08-27 15:35 UTC (permalink / raw)
To: linux-fbdev
Hi Simon,
On Monday 27 August 2012 17:54:52 Simon Horman wrote:
> On Thu, Aug 16, 2012 at 03:00:35PM +0200, Laurent Pinchart wrote:
> > Hi everybody,
> >
> > As part of a general panel API implementation (more on that a bit later),
> > I've cleaned up panel support in the LCDC driver and in the related board
> > code. The result is 19 patches independent of the generic panel API that
> > I would like to get reviewed by the respective board maintainers.
>
> Hi Paul,
>
> I'm happy for you to take all of this, including the mach-shmobile
> portions through your tree if that works for you.
I usually push the LCDC patches through the fbdev tree. I'm fine with both
options though.
> > Laurent Pinchart (19):
> > fbdev: sh_mobile_lcdc: Get display dimensions from the channel
> > structure
> > fbdev: sh_mobile_lcdc: Rename mode argument to modes
> > fbdev: sh_mobile_lcdc: Remove priv argument from channel and overlay
> > init
> > ARM: mach-shmobile: ag5evm: Add LCDC tx_dev field to platform data
> > fbdev: sh_mipi_dsi: Add channel field to platform data
> > ARM: mach-shmobile: Initiliaze the new sh_mipi_dsi_info channel field
> > fbdev: sh_mipi_dsi: Use the sh_mipi_dsi_info channel field
> > fbdev: sh_mipi_dsi: Use the LCDC entity default mode
> > fbdev: sh_mipi_dsi: Remove last reference to LCDC platform data
> > ARM: mach-shmobile: Remove the unused sh_mipi_dsi_info lcd_chan field
> > fbdev: sh_mipi_dsi: Remove the unused sh_mipi_dsi_info lcd_chan field
> > fbdev: sh_mobile_lcdc: Store the backlight brightness internally
> > ARM: mach-shmobile: mackerel: Removed unused get_brightness callback
> > sh: ap325rxa: Remove unused get_brightness LCDC callback
> > sh: ecovec24: Remove unused get_brightness LCDC callback
> > fbdev: sh_mobile_lcdc: Remove unused get_brightness pdata callback
> > ARM: mach-shmobile: ag5evm: Use the backlight API for brightness
> > control
> > sh: kfr2r09: Use the backlight API for brightness control
> > fbdev: sh_mobile_lcdc: Make sh_mobile_lcdc_sys_bus_ops static
> >
> > arch/arm/mach-shmobile/board-ag5evm.c | 198 +++++++++++-----------
> > arch/arm/mach-shmobile/board-ap4evb.c | 4 +-
> > arch/arm/mach-shmobile/board-mackerel.c | 6 -
> > arch/sh/boards/mach-ap325rxa/setup.c | 6 -
> > arch/sh/boards/mach-ecovec24/setup.c | 6 -
> > arch/sh/boards/mach-kfr2r09/lcd_wqvga.c | 16 +--
> > arch/sh/boards/mach-kfr2r09/setup.c | 7 +-
> > arch/sh/include/mach-kfr2r09/mach/kfr2r09.h | 6 +-
> > drivers/video/sh_mipi_dsi.c | 69 ++++------
> > drivers/video/sh_mobile_lcdcfb.c | 54 ++++----
> > drivers/video/sh_mobile_lcdcfb.h | 1 +
> > include/video/sh_mipi_dsi.h | 4 +-
> > include/video/sh_mobile_lcdc.h | 1 -
> > 13 files changed, 172 insertions(+), 206 deletions(-)
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 00/19] SH Mobile LCDC panel cleanup (including board code)
2012-08-16 13:00 [PATCH 00/19] SH Mobile LCDC panel cleanup (including board code) Laurent Pinchart
2012-08-27 8:54 ` Simon Horman
2012-08-27 15:35 ` Laurent Pinchart
@ 2012-08-29 6:07 ` Simon Horman
2012-08-29 14:58 ` Laurent Pinchart
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Simon Horman @ 2012-08-29 6:07 UTC (permalink / raw)
To: linux-fbdev
Hi Laurent,
On Mon, Aug 27, 2012 at 05:35:46PM +0200, Laurent Pinchart wrote:
> Hi Simon,
>
> On Monday 27 August 2012 17:54:52 Simon Horman wrote:
> > On Thu, Aug 16, 2012 at 03:00:35PM +0200, Laurent Pinchart wrote:
> > > Hi everybody,
> > >
> > > As part of a general panel API implementation (more on that a bit later),
> > > I've cleaned up panel support in the LCDC driver and in the related board
> > > code. The result is 19 patches independent of the generic panel API that
> > > I would like to get reviewed by the respective board maintainers.
> >
> > Hi Paul,
> >
> > I'm happy for you to take all of this, including the mach-shmobile
> > portions through your tree if that works for you.
>
> I usually push the LCDC patches through the fbdev tree. I'm fine with both
> options though.
I'm happy for you to handle things in your normal way.
I guess that means that once the LCDC changes are in the fbdev tree
Paul should take the linux-sh changes and I should take the shmobile
changes, is that correct?
>
> > > Laurent Pinchart (19):
> > > fbdev: sh_mobile_lcdc: Get display dimensions from the channel
> > > structure
> > > fbdev: sh_mobile_lcdc: Rename mode argument to modes
> > > fbdev: sh_mobile_lcdc: Remove priv argument from channel and overlay
> > > init
> > > ARM: mach-shmobile: ag5evm: Add LCDC tx_dev field to platform data
> > > fbdev: sh_mipi_dsi: Add channel field to platform data
> > > ARM: mach-shmobile: Initiliaze the new sh_mipi_dsi_info channel field
> > > fbdev: sh_mipi_dsi: Use the sh_mipi_dsi_info channel field
> > > fbdev: sh_mipi_dsi: Use the LCDC entity default mode
> > > fbdev: sh_mipi_dsi: Remove last reference to LCDC platform data
> > > ARM: mach-shmobile: Remove the unused sh_mipi_dsi_info lcd_chan field
> > > fbdev: sh_mipi_dsi: Remove the unused sh_mipi_dsi_info lcd_chan field
> > > fbdev: sh_mobile_lcdc: Store the backlight brightness internally
> > > ARM: mach-shmobile: mackerel: Removed unused get_brightness callback
> > > sh: ap325rxa: Remove unused get_brightness LCDC callback
> > > sh: ecovec24: Remove unused get_brightness LCDC callback
> > > fbdev: sh_mobile_lcdc: Remove unused get_brightness pdata callback
> > > ARM: mach-shmobile: ag5evm: Use the backlight API for brightness
> > > control
> > > sh: kfr2r09: Use the backlight API for brightness control
> > > fbdev: sh_mobile_lcdc: Make sh_mobile_lcdc_sys_bus_ops static
> > >
> > > arch/arm/mach-shmobile/board-ag5evm.c | 198 +++++++++++-----------
> > > arch/arm/mach-shmobile/board-ap4evb.c | 4 +-
> > > arch/arm/mach-shmobile/board-mackerel.c | 6 -
> > > arch/sh/boards/mach-ap325rxa/setup.c | 6 -
> > > arch/sh/boards/mach-ecovec24/setup.c | 6 -
> > > arch/sh/boards/mach-kfr2r09/lcd_wqvga.c | 16 +--
> > > arch/sh/boards/mach-kfr2r09/setup.c | 7 +-
> > > arch/sh/include/mach-kfr2r09/mach/kfr2r09.h | 6 +-
> > > drivers/video/sh_mipi_dsi.c | 69 ++++------
> > > drivers/video/sh_mobile_lcdcfb.c | 54 ++++----
> > > drivers/video/sh_mobile_lcdcfb.h | 1 +
> > > include/video/sh_mipi_dsi.h | 4 +-
> > > include/video/sh_mobile_lcdc.h | 1 -
> > > 13 files changed, 172 insertions(+), 206 deletions(-)
>
> --
> Regards,
>
> Laurent Pinchart
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 00/19] SH Mobile LCDC panel cleanup (including board code)
2012-08-16 13:00 [PATCH 00/19] SH Mobile LCDC panel cleanup (including board code) Laurent Pinchart
` (2 preceding siblings ...)
2012-08-29 6:07 ` Simon Horman
@ 2012-08-29 14:58 ` Laurent Pinchart
2012-08-30 6:23 ` Paul Mundt
2012-08-30 6:27 ` Simon Horman
5 siblings, 0 replies; 7+ messages in thread
From: Laurent Pinchart @ 2012-08-29 14:58 UTC (permalink / raw)
To: linux-fbdev
Hi Simon,
On Wednesday 29 August 2012 15:07:49 Simon Horman wrote:
> On Mon, Aug 27, 2012 at 05:35:46PM +0200, Laurent Pinchart wrote:
> > On Monday 27 August 2012 17:54:52 Simon Horman wrote:
> > > On Thu, Aug 16, 2012 at 03:00:35PM +0200, Laurent Pinchart wrote:
> > > > Hi everybody,
> > > >
> > > > As part of a general panel API implementation (more on that a bit
> > > > later), I've cleaned up panel support in the LCDC driver and in the
> > > > related board code. The result is 19 patches independent of the
> > > > generic panel API that I would like to get reviewed by the respective
> > > > board maintainers.
> > >
> > > Hi Paul,
> > >
> > > I'm happy for you to take all of this, including the mach-shmobile
> > > portions through your tree if that works for you.
> >
> > I usually push the LCDC patches through the fbdev tree. I'm fine with both
> > options though.
>
> I'm happy for you to handle things in your normal way.
>
> I guess that means that once the LCDC changes are in the fbdev tree
> Paul should take the linux-sh changes and I should take the shmobile
> changes, is that correct?
To avoid bisection breakages all the patches should go through the same tree.
This will of course increase the chances of merge conflicts. Would you rather
take them all through linux-sh ?
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 00/19] SH Mobile LCDC panel cleanup (including board code)
2012-08-16 13:00 [PATCH 00/19] SH Mobile LCDC panel cleanup (including board code) Laurent Pinchart
` (3 preceding siblings ...)
2012-08-29 14:58 ` Laurent Pinchart
@ 2012-08-30 6:23 ` Paul Mundt
2012-08-30 6:27 ` Simon Horman
5 siblings, 0 replies; 7+ messages in thread
From: Paul Mundt @ 2012-08-30 6:23 UTC (permalink / raw)
To: linux-fbdev
(Resending due to mail server silliness, apologies for any duplicates)
On Mon, Aug 27, 2012 at 05:54:52PM +0900, Simon Horman wrote:
> On Thu, Aug 16, 2012 at 03:00:35PM +0200, Laurent Pinchart wrote:
> > Hi everybody,
> >
> > As part of a general panel API implementation (more on that a bit later), I've
> > cleaned up panel support in the LCDC driver and in the related board code. The
> > result is 19 patches independent of the generic panel API that I would like to
> > get reviewed by the respective board maintainers.
>
> Hi Paul,
>
> I'm happy for you to take all of this, including the mach-shmobile
> portions through your tree if that works for you.
..
> > arch/arm/mach-shmobile/board-ag5evm.c | 198 ++++++++++++++-------------
> > arch/arm/mach-shmobile/board-ap4evb.c | 4 +-
> > arch/arm/mach-shmobile/board-mackerel.c | 6 -
> > arch/sh/boards/mach-ap325rxa/setup.c | 6 -
> > arch/sh/boards/mach-ecovec24/setup.c | 6 -
> > arch/sh/boards/mach-kfr2r09/lcd_wqvga.c | 16 +--
> > arch/sh/boards/mach-kfr2r09/setup.c | 7 +-
> > arch/sh/include/mach-kfr2r09/mach/kfr2r09.h | 6 +-
> > drivers/video/sh_mipi_dsi.c | 69 ++++------
> > drivers/video/sh_mobile_lcdcfb.c | 54 ++++----
> > drivers/video/sh_mobile_lcdcfb.h | 1 +
> > include/video/sh_mipi_dsi.h | 4 +-
> > include/video/sh_mobile_lcdc.h | 1 -
> > 13 files changed, 172 insertions(+), 206 deletions(-)
> >
Based on the diffstat, the bulk of the change is in the mach-shmobile
directory, so this probably ought to go through your tree to minimize the
potential for merge conflicts. All of the SH stuff is trivival, so
shouldn't be an issue. You're welcome to attach my Acked-by if you like.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 00/19] SH Mobile LCDC panel cleanup (including board code)
2012-08-16 13:00 [PATCH 00/19] SH Mobile LCDC panel cleanup (including board code) Laurent Pinchart
` (4 preceding siblings ...)
2012-08-30 6:23 ` Paul Mundt
@ 2012-08-30 6:27 ` Simon Horman
5 siblings, 0 replies; 7+ messages in thread
From: Simon Horman @ 2012-08-30 6:27 UTC (permalink / raw)
To: linux-fbdev
On Wed, Aug 29, 2012 at 04:58:10PM +0200, Laurent Pinchart wrote:
> Hi Simon,
>
> On Wednesday 29 August 2012 15:07:49 Simon Horman wrote:
> > On Mon, Aug 27, 2012 at 05:35:46PM +0200, Laurent Pinchart wrote:
> > > On Monday 27 August 2012 17:54:52 Simon Horman wrote:
> > > > On Thu, Aug 16, 2012 at 03:00:35PM +0200, Laurent Pinchart wrote:
> > > > > Hi everybody,
> > > > >
> > > > > As part of a general panel API implementation (more on that a bit
> > > > > later), I've cleaned up panel support in the LCDC driver and in the
> > > > > related board code. The result is 19 patches independent of the
> > > > > generic panel API that I would like to get reviewed by the respective
> > > > > board maintainers.
> > > >
> > > > Hi Paul,
> > > >
> > > > I'm happy for you to take all of this, including the mach-shmobile
> > > > portions through your tree if that works for you.
> > >
> > > I usually push the LCDC patches through the fbdev tree. I'm fine with both
> > > options though.
> >
> > I'm happy for you to handle things in your normal way.
> >
> > I guess that means that once the LCDC changes are in the fbdev tree
> > Paul should take the linux-sh changes and I should take the shmobile
> > changes, is that correct?
>
> To avoid bisection breakages all the patches should go through the same tree.
> This will of course increase the chances of merge conflicts. Would you rather
> take them all through linux-sh ?
I'm happy for them to go through the fbdev tree.
Feel free to ad my Ack.
Paul has indicated a similar sentiment in another email in this thread.
^ permalink raw reply [flat|nested] 7+ messages in thread