From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Alexandre Courbot <acourbot@nvidia.com>
Cc: Stephen Warren <swarren@nvidia.com>,
Thierry Reding <thierry.reding@avionic-design.de>,
Simon Glass <sjg@chromium.org>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Anton Vorontsov <cbou@mail.ru>,
David Woodhouse <dwmw2@infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
Leela Krishna Amudala <l.krishna@samsung.com>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fbdev@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-pm@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v6 1/4] Runtime Interpreted Power Sequences
Date: Thu, 13 Sep 2012 08:09:55 +0000 [thread overview]
Message-ID: <20120913080953.GC20959@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1347443867-18868-2-git-send-email-acourbot@nvidia.com>
On Wed, Sep 12, 2012 at 06:57:44PM +0900, Alexandre Courbot wrote:
> Some device drivers (panel backlights especially) need to follow precise
> sequences for powering on and off, involving gpios, regulators, PWMs
> with a precise powering order and delays to respect between each steps.
> These sequences are board-specific, and do not belong to a particular
> driver - therefore they have been performed by board-specific hook
> functions to far.
It does make me a little sad that the DT bindings need to specify the
number of steps but otherwise this looks good (modulo the minor comments
Stephen had as well):
Reviewed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
I think regardless of the current discussion about some of the
applications (like pwm-backlight) there are going to be cases where this
is useful even if it ends up being more as library code for drivers than
as something that users work with directly.
next prev parent reply other threads:[~2012-09-13 8:09 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 9:57 [PATCH v6 0/4] Runtime Interpreted Power Sequences Alexandre Courbot
2012-09-12 9:57 ` [PATCH v6 2/4] pwm_backlight: use power sequences Alexandre Courbot
2012-09-12 22:15 ` Stephen Warren
[not found] ` <1347443867-18868-1-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-09-12 9:57 ` [PATCH v6 1/4] Runtime Interpreted Power Sequences Alexandre Courbot
2012-09-12 22:07 ` Stephen Warren
2012-09-13 6:02 ` Alex Courbot
2012-09-13 15:44 ` Stephen Warren
[not found] ` <1347443867-18868-2-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-09-13 5:45 ` Tomi Valkeinen
2012-09-13 6:08 ` Alex Courbot
2012-09-13 6:22 ` Tomi Valkeinen
2012-09-13 6:36 ` Alex Courbot
2012-09-13 6:54 ` Tomi Valkeinen
2012-09-13 7:00 ` Sascha Hauer
[not found] ` <20120913070012.GC6180-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-09-13 7:03 ` Tomi Valkeinen
2012-09-13 7:18 ` Sascha Hauer
[not found] ` <20120913071829.GE6180-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-09-13 7:27 ` Tomi Valkeinen
2012-09-13 7:21 ` Alex Courbot
2012-09-13 7:29 ` Thierry Reding
2012-09-13 7:50 ` Sascha Hauer
2012-09-13 8:21 ` Alex Courbot
2012-09-13 8:26 ` Thierry Reding
[not found] ` <20120913072920.GA11459-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
2012-09-13 8:00 ` Tomi Valkeinen
2012-09-13 8:32 ` Thierry Reding
2012-09-13 7:08 ` Alex Courbot
2012-09-13 15:37 ` Stephen Warren
2012-09-13 8:09 ` Mark Brown [this message]
2012-09-12 9:57 ` [PATCH v6 3/4] tegra: dt: add label to tegra20's PWM Alexandre Courbot
2012-09-12 9:57 ` [PATCH v6 4/4] tegra: ventana: add pwm backlight DT nodes Alexandre Courbot
[not found] ` <1347443867-18868-5-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-09-12 21:23 ` Stephen Warren
2012-09-12 21:27 ` [PATCH v6 0/4] Runtime Interpreted Power Sequences Stephen Warren
[not found] ` <5050FE28.2080502-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-09-12 21:33 ` Anton Vorontsov
2012-09-13 5:53 ` Alex Courbot
2012-09-13 5:50 ` Tomi Valkeinen
2012-09-13 6:23 ` Alex Courbot
2012-09-13 6:25 ` Mark Brown
2012-09-13 6:42 ` Alex Courbot
2012-09-13 7:19 ` Mark Brown
2012-09-13 7:26 ` Alex Courbot
2012-09-13 7:29 ` Mark Brown
2012-09-13 15:24 ` Stephen Warren
2012-09-19 3:01 ` Mark Brown
[not found] ` <5051FAC5.40501-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-10-03 8:24 ` Alex Courbot
[not found] ` <506BF62F.6040308-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-10-03 15:30 ` Stephen Warren
2012-09-13 6:42 ` Tomi Valkeinen
2012-09-13 6:48 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120913080953.GC20959@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=acourbot@nvidia.com \
--cc=arnd@arndb.de \
--cc=cbou@mail.ru \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dwmw2@infradead.org \
--cc=grant.likely@secretlab.ca \
--cc=l.krishna@samsung.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=sjg@chromium.org \
--cc=swarren@nvidia.com \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).