From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steffen Trumtrar Date: Fri, 05 Oct 2012 15:51:21 +0000 Subject: Re: [PATCH 2/2 v6] of: add generic videomode description Message-Id: <20121005155121.GA2053@pengutronix.de> List-Id: References: <1349373560-11128-1-git-send-email-s.trumtrar@pengutronix.de> <1349373560-11128-3-git-send-email-s.trumtrar@pengutronix.de> <506DDA94.1090702@wwwdotorg.org> In-Reply-To: <506DDA94.1090702@wwwdotorg.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Stephen Warren Cc: devicetree-discuss@lists.ozlabs.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Tomi Valkeinen , Laurent Pinchart , linux-media@vger.kernel.org On Thu, Oct 04, 2012 at 12:51:00PM -0600, Stephen Warren wrote: > On 10/04/2012 11:59 AM, Steffen Trumtrar wrote: > > Get videomode from devicetree in a format appropriate for the > > backend. drm_display_mode and fb_videomode are supported atm. > > Uses the display signal timings from of_display_timings > > > +++ b/drivers/of/of_videomode.c > > > +int videomode_from_timing(struct display_timings *disp, struct videomode *vm, > > > + st = display_timings_get(disp, index); > > + > > + if (!st) { > > It's a little odd to leave a blank line between those two lines. Hm, well okay. That can be remedied > > Only half of the code in this file seems OF-related; the routines to > convert a timing to a videomode or drm display mode seem like they'd be > useful outside device tree, so I wonder if putting them into > of_videomode.c is the correct thing to do. Still, it's probably not a > big deal. > I am not sure, what the appropriate way to do this is. I can split it up (again). -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |