From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steffen Trumtrar Date: Wed, 31 Oct 2012 16:49:13 +0000 Subject: Re: [PATCH v7 5/8] fbmon: add videomode helpers Message-Id: <20121031164913.GA9054@pengutronix.de> List-Id: References: <1351675689-26814-1-git-send-email-s.trumtrar@pengutronix.de> <1351675689-26814-6-git-send-email-s.trumtrar@pengutronix.de> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Manjunathappa, Prakash" Cc: "devicetree-discuss@lists.ozlabs.org" , Rob Herring , "linux-fbdev@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Laurent Pinchart , Thierry Reding , Guennady Liakhovetski , "linux-media@vger.kernel.org" , "Valkeinen, Tomi" , Stephen Warren , "kernel@pengutronix.de" Hi Prakash! On Wed, Oct 31, 2012 at 03:30:03PM +0000, Manjunathappa, Prakash wrote: > Hi Steffen, > > On Wed, Oct 31, 2012 at 14:58:05, Steffen Trumtrar wrote: > > Add a function to convert from the generic videomode to a fb_videomode. > > > > Signed-off-by: Steffen Trumtrar > > --- > > drivers/video/fbmon.c | 36 ++++++++++++++++++++++++++++++++++++ > > include/linux/fb.h | 2 ++ > > 2 files changed, 38 insertions(+) > > > > diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c > > index cef6557..b9e6ab3 100644 > > --- a/drivers/video/fbmon.c > > +++ b/drivers/video/fbmon.c > > @@ -1373,6 +1373,42 @@ int fb_get_mode(int flags, u32 val, struct fb_var_screeninfo *var, struct fb_inf > > kfree(timings); > > return err; > > } > > + > > +#if IS_ENABLED(CONFIG_VIDEOMODE) > > +int videomode_to_fb_videomode(struct videomode *vm, struct fb_videomode *fbmode) > > +{ > > + fbmode->xres = vm->hactive; > > + fbmode->left_margin = vm->hback_porch; > > + fbmode->right_margin = vm->hfront_porch; > > + fbmode->hsync_len = vm->hsync_len; > > + > > + fbmode->yres = vm->vactive; > > + fbmode->upper_margin = vm->vback_porch; > > + fbmode->lower_margin = vm->vfront_porch; > > + fbmode->vsync_len = vm->vsync_len; > > + > > + fbmode->pixclock = KHZ2PICOS(vm->pixelclock / 1000); > > + > > + fbmode->sync = 0; > > + fbmode->vmode = 0; > > + if (vm->hah) > > + fbmode->sync |= FB_SYNC_HOR_HIGH_ACT; > > + if (vm->vah) > > + fbmode->sync |= FB_SYNC_VERT_HIGH_ACT; > > + if (vm->interlaced) > > + fbmode->vmode |= FB_VMODE_INTERLACED; > > + if (vm->doublescan) > > + fbmode->vmode |= FB_VMODE_DOUBLE; > > + > > "pixelclk-inverted" property of the panel is not percolated fb_videomode. > Please let me know if I am missing something. > You are right. I forgot that :( Regards, Steffen -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |