From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Date: Fri, 09 Nov 2012 08:06:04 +0000 Subject: Re: [PATCH] pwm-backlight: Pinctrl-fy Message-Id: <20121109080604.GA25611@avionic-0098.mockup.avionic-design.de> MIME-Version: 1 Content-Type: multipart/mixed; boundary="CE+1k2dSO48ffgeK" List-Id: References: <1351699047-4487-1-git-send-email-panto@antoniou-consulting.com> In-Reply-To: <1351699047-4487-1-git-send-email-panto@antoniou-consulting.com> To: Pantelis Antoniou Cc: Richard Purdie , Florian Tobias Schandinat , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Koen Kooi , Matt Porter , Russ Dill , linux-omap@vger.kernel.org, Linus Walleij --CE+1k2dSO48ffgeK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 31, 2012 at 05:57:27PM +0200, Pantelis Antoniou wrote: > Enable pinctrl for pwm-backlight. >=20 > Signed-off-by: Pantelis Antoniou > --- > drivers/video/backlight/pwm_bl.c | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/p= wm_bl.c > index 0c91023..f3b6194 100644 > --- a/drivers/video/backlight/pwm_bl.c > +++ b/drivers/video/backlight/pwm_bl.c > @@ -20,6 +20,8 @@ > #include > #include > #include > +#include > +#include > =20 > struct pwm_bl_data { > struct pwm_device *pwm; > @@ -180,9 +182,14 @@ static int pwm_backlight_probe(struct platform_devic= e *pdev) > struct backlight_properties props; > struct backlight_device *bl; > struct pwm_bl_data *pb; > + struct pinctrl *pinctrl; > unsigned int max; > int ret; > =20 > + pinctrl =3D devm_pinctrl_get_select_default(&pdev->dev); > + if (IS_ERR(pinctrl)) > + dev_warn(&pdev->dev, "unable to select pin group\n"); > + I just saw this done in a similar way in some other driver and then remembered your patch. When I reviewed this I wasn't sure if a warning was good enough in this case. I've checked the kernel tree and it seems like a majority handled this as failure instead of a warning. I took a look at the pinctrl core and it seems like indeed if neither pinctrl is enabled or if there isn't actually a pinmux configuration for a device, then devm_pinctrl_get_select_default() will actually not return an error, so in those cases where an error is returned it should actually be handled as a fatal error. I'm Cc'ing Linus Walleij, maybe he knows what to do. Thierry > if (!data) { > ret =3D pwm_backlight_parse_dt(&pdev->dev, &defdata); > if (ret < 0) { > --=20 > 1.7.12 >=20 >=20 >=20 --CE+1k2dSO48ffgeK Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJQnLlsAAoJEN0jrNd/PrOhPyAQAKKFa+hm98eF89n9eweQiQ/J VlzY2S6XiSOZaCGbekwla/B7lh6Tq2rqbUM3OZYdDKGvY/sCDcBZRK/8UmmwSoVx GvZD+6Mq0IRnBkF0xJPO5bYp1lAVOosDP9XYucmIKK5USqV67TKg/Tims1N3yEim 29nnJlLNgHDrbkEQ3gVHdQB9Pfb2mYvbEflGOf6Wc+keVmRNTYtgmjmxNY18Igi8 h7Gxb/15Ic0ytIQdtZ0zRos2V1lfvreWAxCCSl/4i1jwGjVY2Cy3U+K8fNiQy0nA fBV5OpbwjUCSgia8vQGZ1gA8+saO//ys0OV2Ul8ejztDKW/DN1z3D4fLxCDCeAOE e5LCfd6IVpFeU/SHSWF7Yw30WisvCYrc7QCnaHR2v1W8q1rEtGwLZEUIrPq5NO80 eyoULAQs8mL/AyYQVArU/vzoWf0ZP6VNQHqVfCKnXRGdbD5N+mhkCOIfhG/hLSg2 VcYd3ZmZ7K3ejhhQ4zRXuJunNdbYMNJ++6rnszdkBFCD18QE/ljWjuQDfUqZ6wOT OxHr9BNnKHqSnXi2N1i0ITBuqQO3UJByiJQATXUhyISMpMRB7lnX1liH4Q2S7j7p 8hHFq8Ixob0ALmSdjY++wOmdnUX5kpmCNa3x/OeQu1CA9r1f4VneJUlPnv3ezSNm L6fBMPqs9Lh7ZtLRgUZA =inHc -----END PGP SIGNATURE----- --CE+1k2dSO48ffgeK--