From: Dan Carpenter <dan.carpenter@oracle.com>
To: linux-fbdev@vger.kernel.org
Subject: [patch] backlight: s6e63m0: report ->gamma_table_count correctly
Date: Thu, 24 Jan 2013 07:05:24 +0000 [thread overview]
Message-ID: <20130124070524.GD5611@elgon.mountain> (raw)
gamma_table has 3 arrays which each hold MAX_GAMMA_LEVEL pointers to
int.
The current code sets ->gamma_table_count to 6 on 64bit arches and to 3
on 32 bit arches. It should be 3 on everything.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This is from reading the code. We use ->gamma_table_count in sysfs file
but other than that I'm not sure what it's for. I am not very familiar
with this code.
diff --git a/drivers/video/backlight/s6e63m0.c b/drivers/video/backlight/s6e63m0.c
index 2126b96..9c2677f 100644
--- a/drivers/video/backlight/s6e63m0.c
+++ b/drivers/video/backlight/s6e63m0.c
@@ -766,7 +766,7 @@ static int s6e63m0_probe(struct spi_device *spi)
* know that.
*/
lcd->gamma_table_count - sizeof(gamma_table) / (MAX_GAMMA_LEVEL * sizeof(int));
+ sizeof(gamma_table) / (MAX_GAMMA_LEVEL * sizeof(int *));
ret = device_create_file(&(spi->dev), &dev_attr_gamma_mode);
if (ret < 0)
next reply other threads:[~2013-01-24 7:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 7:05 Dan Carpenter [this message]
2013-01-25 2:22 ` [patch] backlight: s6e63m0: report ->gamma_table_count correctly Jingoo Han
2013-01-30 1:01 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130124070524.GD5611@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).