From: Andrew Morton <akpm@linux-foundation.org>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v5 3/8] video: mmp display controller support
Date: Wed, 30 Jan 2013 21:49:36 +0000 [thread overview]
Message-ID: <20130130134936.d85b5a9e.akpm@linux-foundation.org> (raw)
In-Reply-To: <1358411023-2667-1-git-send-email-zzhu3@marvell.com>
On Thu, 17 Jan 2013 16:23:43 +0800
Zhou Zhu <zzhu3@marvell.com> wrote:
> From: Guoqing Li <ligq@marvell.com>
>
> Marvell mmp series display controller support in mmpdisp subsystem.
> This driver focus on implementation of hardware operations of path/ovly,
> which is defined in mmp display subsystem interface.
> This driver registers all pathes to mmp display framework.
>
> ...
>
> +#define ovly_is_vid(ovly) (ovly->dmafetch_id % 2)
> +#define path_to_path_plat(path) \
> + ((struct mmphw_path_plat *)path->plat_data)
> +#define ovly_to_ctrl(ovly) \
> + (path_to_ctrl(ovly->path))
> +#define path_to_ctrl(path) \
> + (path_to_path_plat(path)->ctrl)
> +#define ctrl_regs(path) \
> + (path_to_ctrl(path)->reg_base)
These could be implemented in C rather than in CPP. The result would
be improved typechecking and improved readability.
>
> ...
>
prev parent reply other threads:[~2013-01-30 21:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 8:23 [PATCH v5 3/8] video: mmp display controller support Zhou Zhu
2013-01-30 21:49 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130130134936.d85b5a9e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).