From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Date: Thu, 31 Jan 2013 13:02:06 +0000 Subject: Re: BUG: circular locking dependency detected Message-Id: <20130131130206.GB13352@kroah.com> List-Id: References: <20130130221946.GA14801@flint.arm.linux.org.uk> <20130131001339.GC14801@flint.arm.linux.org.uk> <20130131054002.GA3697@kroah.com> <20130131092146.GB3361@kroah.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Dave Airlie Cc: Daniel Vetter , Linus Torvalds , Russell King , Andrew Morton , Florian Tobias Schandinat , "linux-fbdev@vger.kernel.org" , Linux Kernel Mailing List , dri-devel On Thu, Jan 31, 2013 at 10:51:27PM +1100, Dave Airlie wrote: > On Thu, Jan 31, 2013 at 8:21 PM, Greg Kroah-Hartman > wrote: > > On Thu, Jan 31, 2013 at 09:21:16AM +0100, Daniel Vetter wrote: > >> On Thu, Jan 31, 2013 at 6:40 AM, Greg Kroah-Hartman > >> wrote: > >> > On Thu, Jan 31, 2013 at 11:26:53AM +1100, Linus Torvalds wrote: > >> >> On Thu, Jan 31, 2013 at 11:13 AM, Russell King wrote: > >> >> > > >> >> > Which may or may not be a good thing depending how you look at it= ; it > >> >> > means that once your kernel blanks, you get a lockdep dump. At t= hat > >> >> > point you lose lockdep checking for everything else because lockd= ep > >> >> > disables itself after the first dump. > >> >> > >> >> Fair enough, we may want to revert the lockdep checking for > >> >> console_lock, and make re-enabling it part of the patch-series that > >> >> fixes the locking. > >> >> > >> >> Daniel/Dave? Does that sound reasonable? > >> > >> Yeah, sounds good. > >> > >> > Reverting the patch is fine with me. Just let me know so I can queu= e it > >> > up again for 3.9. > >> > >> Can you please also pick up the (currently) three locking fixups > >> around fbcon? Just so that we don't repeat the same fun where people > >> complain about lockdep splats, but the fixes are stuck somewhere. And > >> I guess Dave would be happy to not end up as fbcon maintainer ;-) He > >> has a git branch with them at > >> http://cgit.freedesktop.org/~airlied/linux/log/?h=FBcon-locking-fixes > >> though I have a small bikeshed on his last patch pending. > > > > Care to just send me the patches through email when you all get done > > bikesheding? And for some reason I thought Andrew was going to handle > > these fbcon patches, but if not, I'll be glad to take them. >=20 > I'll ship them via my tree at this point I think, since I now need to > queue a revert of the revert on top. >=20 > I have a few vgacon/fbcon fixes that I need to go in this cycle. Ok, I'll gladly let you handle this :) thanks, greg k-h